Summary: | Self registration with a verification by email is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03,18.11.09
|
|
Circulation function: | |||
Bug Depends on: | 23151 | ||
Bug Blocks: | |||
Attachments: |
Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email
Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email |
Description
Jonathan Druart
2019-08-05 13:40:02 UTC
Created attachment 91995 [details] [review] Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email DBIx::Class::Row::store_column(): No such column 'changed_fields' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a new account - Click on the link (see the message_queue table) => Without this patch you get the error => With this patch you will see the login form Updating severity as this is a 'patron facing' feature. Hi Jonathan, is this for a specific version or am I missing something on testing? I have just tested twice on master without the patch and everytime the email verification link worked without error. Indeed I do not recreate this error. I do on 18.11.08 This change is safe anyway. Created attachment 92201 [details] [review] Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email DBIx::Class::Row::store_column(): No such column 'changed_fields' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a new account - Click on the link (see the message_queue table) => Without this patch you get the error => With this patch you will see the login form Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 92209 [details] [review] Bug 23428: (bug 23151 follow-up) Fix self registration with a verification email DBIx::Class::Row::store_column(): No such column 'changed_fields' on Koha::Schema::Result::Borrower at /home/vagrant/kohaclone/Koha/Object.pm line 75 Test plan: - Turn PatronSelfRegistrationVerifyByEmail on - Register a new account - Click on the link (see the message_queue table) => Without this patch you get the error => With this patch you will see the login form Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |