Summary: | having Date of birth in PatronSelfModificationBorrowerUnwantedField causes DOB to be nullified | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | OPAC | Assignee: | Liz Rea <wizzyrea> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | major | ||
Priority: | P5 - low | CC: | cbrannon, fridolin.somers, lucas, martin.renvoize, wizzyrea |
Version: | 18.11 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.03,18.11.09
|
|
Attachments: |
Bug 23431 - Don't nullify DOB if it's hidden by sysprefs
Bug 23431: Don't nullify DOB if it's hidden by sysprefs Bug 23431: Don't nullify DOB if it's hidden by sysprefs Bug 23431: Don't nullify DOB if it's hidden by sysprefs |
Description
Liz Rea
2019-08-05 14:49:23 UTC
+1 Confirmed Created attachment 92021 [details] [review] Bug 23431 - Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Created attachment 92027 [details] [review] Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Created attachment 92033 [details] [review] Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 92068 [details] [review] Bug 23431: Don't nullify DOB if it's hidden by sysprefs To test: Turn on OPACPatronDetails put dateofbirth in PatronSelfModificationBorrowerUnwantedField Have a patron with a set date of birth Attempt any modification on that patron through the OPAC The date of birth will be one of the fields changed for that borrower when you check it in the staff intranet. Apply this patch, repeat the above. Date of birth will not be one of the changed fields. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch that works as expected.. It would have been nice to have an accompanying selenium regression test, but I don't feel it warrants a QA failure for it (especially as it's a major). Passing QA Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.03 backported to 18.11.x for 18.11.09 |