| Summary: | Clean up subscription detail template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, maryse.simard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 23448: Clean up subscription detail template
Bug 23448: (follow-up) Add comments on markup structure Bug 23448: Clean up subscription detail template Bug 23448: (follow-up) Add comments on markup structure Bug 23448: Clean up subscription detail template Bug 23448: (follow-up) Add comments on markup structure |
||
|
Description
Katrin Fischer
2019-08-10 20:11:58 UTC
Created attachment 92155 [details] [review] Bug 23448: Clean up subscription detail template This patch makes a number of corrections to the subscription detail page: Re-indented consistently with four spaces. Removed invalid attributes. Added missing </div>. To test, apply the patch and go to Serials. Search for a subscription and view the details page. The page should look correct. Validating the source should return no errors. Created attachment 92156 [details] [review] Bug 23448: (follow-up) Add comments on markup structure This patch adds comments to the markup in order to highlight the structure of the page. Created attachment 92326 [details] [review] Bug 23448: Clean up subscription detail template This patch makes a number of corrections to the subscription detail page: Re-indented consistently with four spaces. Removed invalid attributes. Added missing </div>. To test, apply the patch and go to Serials. Search for a subscription and view the details page. The page should look correct. Validating the source should return no errors. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 92327 [details] [review] Bug 23448: (follow-up) Add comments on markup structure This patch adds comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 92335 [details] [review] Bug 23448: Clean up subscription detail template This patch makes a number of corrections to the subscription detail page: Re-indented consistently with four spaces. Removed invalid attributes. Added missing </div>. To test, apply the patch and go to Serials. Search for a subscription and view the details page. The page should look correct. Validating the source should return no errors. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92336 [details] [review] Bug 23448: (follow-up) Add comments on markup structure This patch adds comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Enhancement not pushed to 19.05.x |