Bug 23458

Summary: Clean up holds template in the staff client
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, maryse.simard
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 17057    
Bug Blocks:    
Attachments: Bug 23458: Clean up holds template in the staff client
Bug 23458: (follow-up) Add comments to markup
Bug 23458: Clean up holds template in the staff client
Bug 23458: (follow-up) Add comments to markup
Bug 23458: Clean up holds template in the staff client
Bug 23458: (follow-up) Add comments to markup

Description Owen Leonard 2019-08-13 16:59:52 UTC
I would like to reindent reserve/request.tt: Remove tabs, correct indentation, add some comments to clarify the structure.
Comment 1 Owen Leonard 2019-08-15 15:49:15 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2019-08-15 15:49:17 UTC Comment hidden (obsolete)
Comment 3 Maryse Simard 2019-08-16 18:45:56 UTC Comment hidden (obsolete)
Comment 4 Maryse Simard 2019-08-16 18:46:02 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2019-08-17 06:05:08 UTC
Created attachment 92331 [details] [review]
Bug 23458: Clean up holds template in the staff client

This patch reindents reserve/request.tt to use four spaces and
to eliminate tabs, following coding guidelines. Trailing white space has
been removed.

To test, apply the patch and use your preferred method for checking the
differences between files while ignoring whitespace. I use diff with the
"-w" flag, but I'm no diffctator.

Test the process of placing a hold in the staff client: A single hold,
multiple holds, etc. Everything should work correctly.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2019-08-17 06:05:11 UTC
Created attachment 92332 [details] [review]
Bug 23458: (follow-up) Add comments to markup

This patch adds a few comments to the markup in order to highlight the
structure of the page.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Martin Renvoize 2019-08-19 09:25:25 UTC
Nice work!

Pushed to master for 19.11.00
Comment 8 Fridolin Somers 2019-09-05 15:02:04 UTC
Enhancement not pushed to 19.05.x