Summary: | When writing off a fine, the title of the patron is shown as description | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Fines and fees | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | hayleypelham, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00, 19.05.06, 18.11.12
|
|
Circulation function: | |||
Attachments: |
Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee
Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee |
Description
Katrin Fischer
2019-08-21 11:18:16 UTC
Confirmed on master now as well. To test: - Make sure that in the account you use a saluation is set (Mr Mrs...) - Create a manual fine - Pay or Writeoff the fine using the buttons next to the fine (not at the bottom) - Look at the description shown before saving (In reply to Katrin Fischer from comment #1) > Confirmed on master now as well. > > To test: > - Make sure that in the account you use a saluation is set (Mr Mrs...) > - Create a manual fine > - Pay or Writeoff the fine using the buttons next to the fine (not at the > bottom) > - Look at the description shown before saving It only happens for writeoff. Created attachment 94986 [details] [review] Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Created attachment 94992 [details] [review] Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Thank you Severine! Created attachment 95116 [details] [review] Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch works as expected.. passing qa Nice work! Pushed to master for 19.11.00 We found this in 18.11 - please backport! :) backported to 19.05.x for 19.05.06 Backported to 18.11.x for 18.11.12 Thx Lucas and Hayley :) |