| Summary: | OPAC search facet header should not be a link at larger browser widths | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, lucas, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23481 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 23492: OPAC search facet header should not be a link at larger browser widths
Bug 23492: OPAC search facet header should not be a link at larger browser widths Bug 23492: OPAC search facet header should not be a link at larger browser widths |
||
Created attachment 92440 [details] [review] Bug 23492: OPAC search facet header should not be a link at larger browser widths This patch adds some JavaScript-driven "breakpoints" to the OPAC so that on the search results page the "Refine your search" heading has different behaviors depending on whether facets are being displayed as a sidebar. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to the OPAC and resize your browser to be greater than ~ 800px wide. - Perform a catalog search which will return several results. - In the left-hand sidebar of the search results page, the "Refine your search" heading should not be styled like a link. Hovering over it with the mouse should not change the cursor to the pointing-hand. - Narrow your browser window until the sidebar collapses. - The "Refine your search" heading should now be styled as a link, with a right-arrow icon before it. - Clicking it should expand the facets. The icon should change to a down-arrow. - Widen your browser window and test again. - Perform the same tests when starting with a narrow browser window. Created attachment 92442 [details] [review] Bug 23492: OPAC search facet header should not be a link at larger browser widths This patch adds some JavaScript-driven "breakpoints" to the OPAC so that on the search results page the "Refine your search" heading has different behaviors depending on whether facets are being displayed as a sidebar. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to the OPAC and resize your browser to be greater than ~ 800px wide. - Perform a catalog search which will return several results. - In the left-hand sidebar of the search results page, the "Refine your search" heading should not be styled like a link. Hovering over it with the mouse should not change the cursor to the pointing-hand. - Narrow your browser window until the sidebar collapses. - The "Refine your search" heading should now be styled as a link, with a right-arrow icon before it. - Clicking it should expand the facets. The icon should change to a down-arrow. - Widen your browser window and test again. - Perform the same tests when starting with a narrow browser window. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Having never signed off on a bug where it is necessary to regenerate the CSS I did this: -Applied patch -regenerated CSS -Tested -git reset --hard origin/master -Re-applied the patch -Signed off. Created attachment 92447 [details] [review] Bug 23492: OPAC search facet header should not be a link at larger browser widths This patch adds some JavaScript-driven "breakpoints" to the OPAC so that on the search results page the "Refine your search" heading has different behaviors depending on whether facets are being displayed as a sidebar. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to the OPAC and resize your browser to be greater than ~ 800px wide. - Perform a catalog search which will return several results. - In the left-hand sidebar of the search results page, the "Refine your search" heading should not be styled like a link. Hovering over it with the mouse should not change the cursor to the pointing-hand. - Narrow your browser window until the sidebar collapses. - The "Refine your search" heading should now be styled as a link, with a right-arrow icon before it. - Clicking it should expand the facets. The icon should change to a down-arrow. - Widen your browser window and test again. - Perform the same tests when starting with a narrow browser window. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> RM may want a second QA here - this is tiny though and we are the ones squeaking about it, so I went ahead and PQA *** Bug 23481 has been marked as a duplicate of this bug. *** This looks sane enough to me and a quick test is positive.. happy to accept the PQA as is :) This looks sane enough to me and a quick test is positive.. happy to accept the PQA as is :) Nice work! Pushed to master for 19.11.00 Enhancement not pushed to 19.05.x |
When viewing the OPAC at a browser width < 768 pixels ("mobile view"), the search facets header, "Refine your search" is a link which expands the search facets. In "desktop view," when the facets are not hidden, the "Refine your search" header should not be a link which collapses the facets. Having it look like a link is deceptive because clicking it doesn't do anything useful.