Bug 23495

Summary: Show SMS provider on details tab in patron account in staff
Product: Koha Reporter: Lisette Scheer <lisettepalouse+koha>
Component: PatronsAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: 1joynelson, gmcharlt, kyle.m.hall, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00
Attachments: Bug 23495: Add SMS provider to moremember.tt
Bug 23495: Add SMS provider to moremember.tt
Bug 23495: Add SMS provider to moremember.tt
Bug 23495: Fix if no sms provider defined

Description Lisette Scheer 2019-08-22 19:33:26 UTC
It would be very helpful if the SMS provider would show on moremember.pl either above or below the SMS number. 
Lisette
Comment 1 Nick Clemens 2020-04-23 18:54:40 UTC
Created attachment 103602 [details] [review]
Bug 23495: Add SMS provider to moremember.tt

To test:
1 - Enable SMS using the Email driver
2 - Add an SMS provider under admimistration
3 - Add an SMS number and provider to a patron
4 - Note on the patron details you don't see the provider :-(
5 - Apply patch
6 - Reload
7 - Note you do see the provider :-)
8 - prove t/db_dependent/Koha/Patrons.t
9 - Sign off!
Comment 2 ByWater Sandboxes 2020-04-23 19:23:27 UTC
Created attachment 103604 [details] [review]
Bug 23495: Add SMS provider to moremember.tt

To test:
1 - Enable SMS using the Email driver
2 - Add an SMS provider under admimistration
3 - Add an SMS number and provider to a patron
4 - Note on the patron details you don't see the provider :-(
5 - Apply patch
6 - Reload
7 - Note you do see the provider :-)
8 - prove t/db_dependent/Koha/Patrons.t
9 - Sign off!

Signed-off-by: Lisette <lisetteslatah@gmail.com>
Comment 3 Jonathan Druart 2020-04-24 10:48:43 UTC
Created attachment 103641 [details] [review]
Bug 23495: Add SMS provider to moremember.tt

To test:
1 - Enable SMS using the Email driver
2 - Add an SMS provider under admimistration
3 - Add an SMS number and provider to a patron
4 - Note on the patron details you don't see the provider :-(
5 - Apply patch
6 - Reload
7 - Note you do see the provider :-)
8 - prove t/db_dependent/Koha/Patrons.t
9 - Sign off!

Signed-off-by: Lisette <lisetteslatah@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2020-04-24 10:48:47 UTC
Created attachment 103642 [details] [review]
Bug 23495: Fix if no sms provider defined

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Martin Renvoize 2020-04-29 16:35:57 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 6 Joy Nelson 2020-05-08 22:25:57 UTC
enhancement not backported to 19.11