Summary: | Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, lucas, maryse.simard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
Circulation function: | |||
Bug Depends on: | 21608 | ||
Bug Blocks: | |||
Attachments: |
Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference
Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference |
Description
Owen Leonard
2019-08-23 16:30:09 UTC
Created attachment 92458 [details] [review] Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. Created attachment 92466 [details] [review] Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. Created attachment 92508 [details] [review] Bug 23502: Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference This bug corrects the template logic controlling the display of the "Revert waiting status" and "Revert transit status" buttons on the staff client holds page so that it doesn't depend on having SuspendHoldsIntranet enabled. To test, apply the patch and locate a title which has multiple holds, including: - One waiting hold - One in-transit hold - At least one pending hold View the page with the SuspendHoldsIntranet preference both on and off. The "Revert transit status" and "Revert waiting status" buttons should be displayed either way. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 backported to 18.11.x for 18.11.10 |