| Summary: | Sound material type displays wrong icon in OPAC/Staff details | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | eric.begin, hayleypelham |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00, 19.05.06, 18.11.12
|
|
| Circulation function: | |||
| Attachments: |
Bug 23506: Sound material type displays wrong icon in OPAC details
Bug 23506: Sound material type displays wrong icon in OPAC/Staff details display correct icon in staff client and OPAC Bug 23506: Display correct icon in staff client and OPAC |
||
|
Description
Lucas Gass (lukeg)
2019-08-26 18:43:49 UTC
Correction: MARC21slim2OPACDetail.xsl NOT MARC21slim2intranetDetail.xsl Created attachment 92478 [details] [review] Bug 23506: Sound material type displays wrong icon in OPAC details TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch 5. Look at the opac detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. Created attachment 93162 [details] [review] Bug 23506: Sound material type displays wrong icon in OPAC/Staff details TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch 5. Look at the opac detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. Hi Lucas, can you please fix staff as well? This only includes pictures for the OPAC (also, why do they need to be doubled up?) Kait, When you say double up I assume on mean the presence of two .png's (SO.png and MU.png). I am going to instead use a single .png and direct both Music and Sound to that image. I will also include both the staff and OPAC changes. Created attachment 94840 [details] [review] display correct icon in staff client and OPAC TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page and staff detail for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch and restart_all 5. Look at the opac detail and staff detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. Created attachment 94973 [details] [review] Bug 23506: Display correct icon in staff client and OPAC When the leader6 is set to 'i' the MARC21slim2intranetDetail.xsl attempts to display 'SO.png' which does not exist. TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page and staff detail for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch and restart_all 5. Look at the opac detail and staff detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I fixed the Bug description and commit message. Moving to PQA as it's a really simple fix. Nice work! Pushed to master for 19.11.00 backported to 19.05.x for 19.05.06 Backported to 18.11.x for 18.11.12 |