Bug 23528

Summary:	Show 'log in to add tags' link on all search result entries
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	alexbuckley, hayleypelham, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.11.00, 19.05.08, 18.11.14
Circulation function:
Bug Depends on:	23210
Bug Blocks:
Attachments:	Bug 23528: Show 'log in to add tags' link on all search result entries Bug 23528: Show 'log in to add tags' link on all search result entries Bug 23538: (follow-up) Fix up notices

Description Katrin Fischer 2019-09-01 20:18:27 UTC

Splitting this out as a separate bug report from bug 23210:

(In reply to Lucas Gass from comment #0)
> If a non-authenticated user goes to the search results page they will only
> see the login4tags (Log in to add tags ) text included with the first
> result. This should be included with every result.

Comment 1 Owen Leonard 2019-10-11 14:57:54 UTC

Created attachment 94019 [details] [review]
Bug 23528: Show 'log in to add tags' link on all search result entries

This patch modifies the OPAC search result template so that each result
shows the "Log in to add tags" link instead of just the first.

To test, apply the patch and make sure TagsEnabled and TagsInputOnList
are both enabled.

Perform a search in the OPAC while not logged in. In the list of
results, the "Log in to add tags" link should appear with every result.

Log in to the OPAC and confirm that the "Add tag" link appears as
expected.

Comment 2 Katrin Fischer 2019-10-14 21:24:14 UTC

Created attachment 94106 [details] [review]
Bug 23528: Show 'log in to add tags' link on all search result entries

This patch modifies the OPAC search result template so that each result
shows the "Log in to add tags" link instead of just the first.

To test, apply the patch and make sure TagsEnabled and TagsInputOnList
are both enabled.

Perform a search in the OPAC while not logged in. In the list of
results, the "Log in to add tags" link should appear with every result.

Log in to the OPAC and confirm that the "Add tag" link appears as
expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Martin Renvoize (ashimema) 2019-10-15 13:16:39 UTC

Nice work!

Pushed to master for 19.11.00

Comment 4 Lucas Gass (lukeg) 2020-02-07 14:35:54 UTC

backported to 19.05.x for 19.05.08

Comment 5 Hayley Pelham 2020-02-11 00:03:18 UTC

Backported to 18.11.x for 18.11.14.

Comment 6 Alex Buckley 2022-04-08 01:30:07 UTC

Created attachment 133096 [details] [review]
Bug 23538: (follow-up) Fix up notices

- Add toolkit template (TT) syntax to notices
- Add TT conditionals to notices
- Add translated notice

Sponsored-by: Catalyst IT