Description
Owen Leonard
2019-09-03 18:36:04 UTC
Created attachment 92581 [details] [review] Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Created attachment 92582 [details] [review] Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. Created attachment 92660 [details] [review] Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 92661 [details] [review] Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 92913 [details] [review] Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. Patch did not apply. Merge conflicts. fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23533: (follow-up) Add markup comments Created attachment 96170 [details] [review] Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Created attachment 96171 [details] [review] Bug 23512: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. Created attachment 96172 [details] [review] Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. Created attachment 98189 [details] [review] Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 98190 [details] [review] Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 98359 [details] [review] Bug 23533: Reindent patron entry form (memberentrygen.tt) This patch re-indents the template for patron entry/editing. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, create or edit a patron. Test every aspect of the process. At each step the page should work correctly. Including: - Adult patron - Child patron - Organizational patron - Quick patron add - Duplicate patron - With mandatory fields - With 'BorrowerUnwantedField's defined - With ExtendedPatronAttributes enabled Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 98360 [details] [review] Bug 23533: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the interface or functionality. https://bugs.koha-community.org/show_bug.cgi?id=23533 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. Created attachment 98409 [details] [review] Bug 23533: Remove spaces after/before the open/close parenthesis t/db_dependent/selenium/patrons_search.t is failing because of this change: # got: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 ( iOVAoJj )' # expected: 'Koha › Patrons › Modify patron <strong>fir's"tname</strong> \123 ❤ test_patron_1 (iOVAoJj)' We are adding space after and before the open/close parenthesis of the category code. Followup pushed, thanks Jonathan Enhancement not backported to 19.11.x |