| Summary: | Use patron-title.inc on patron entry page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, maryse.simard, pasi.kallinen, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 23533 | ||
| Bug Blocks: | 23536 | ||
| Attachments: |
Bug 23534: Use patron-title.inc on patron entry page
Bug 23534: Use patron-title.inc on patron entry page Bug 23534: Use patron-title.inc on patron entry page Bug 23534: Use patron-title.inc on patron entry page Bug 23534: Fix selenium tests |
||
|
Description
Owen Leonard
2019-09-03 18:49:47 UTC
Created attachment 92583 [details] [review] Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Created attachment 92662 [details] [review] Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Blocked by bug 23533 currently not applying - please switch back once this is resolved! Created attachment 99767 [details] [review] Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 99826 [details] [review] Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Created attachment 100036 [details] [review] Bug 23534: Fix selenium tests The title of the page now contains lot of info (is it what we really want?) Nice work everyone! Pushed to master for 20.05 This added an untranslatable "Print receipt" button. (In reply to paxed from comment #9) > This added an untranslatable "Print receipt" button. Hi paxed - I don't see it in the patch - can you point it out? (In reply to Katrin Fischer from comment #10) > (In reply to paxed from comment #9) > > This added an untranslatable "Print receipt" button. > > Hi paxed - I don't see it in the patch - can you point it out? Blah, comment ended up on the wrong one, meant bug 23355 not backported to 19.11.x branch due to dependencies |