| Summary: | accountlines.accounttype should match authorised_values.authorised_value in size | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.04
|
|
| Circulation function: | |||
| Attachments: |
Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size
Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size |
||
|
Description
Kyle M Hall (khall)
2019-09-04 17:43:59 UTC
Created attachment 92591 [details] [review] Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Created attachment 92605 [details] [review] Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 92614 [details] [review] Bug 23539: accountlines.accounttype should match authorised_values.authorised_value in size Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I've been meaning to sort this one out for ages.. thanks so much for getting to it :). Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.04 (In reply to Kyle M Hall from comment #0) > Account type is a varchar(16), but the authorised value filling it ( > MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to > this size to avoid truncation of authorised values. Authorised values category is call 'MANUAL_INV' (In reply to Fridolin SOMERS from comment #7) > (In reply to Kyle M Hall from comment #0) > > Account type is a varchar(16), but the authorised value filling it ( > > MANUAL_INVOICE type ) is a varchar(80). Account type should be increased to > > this size to avoid truncation of authorised values. > > Authorised values category is call 'MANUAL_INV' Thanks for the correction Frido! |