Bug 23599

Summary: Koha::Objects::Limit::Library fails if no library passed
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: major    
Priority: P5 - low CC: fridolin.somers, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 23281    
Bug Blocks: 15497    
Attachments: Bug 23599: Regression tests
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed
Bug 23599: Regression tests
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Description Tomás Cohen Arazi 2019-09-12 14:37:04 UTC
The search_with_library_limits method is not tested, and when used in 15497 it proved to explode when no library is passed.
Comment 1 Tomás Cohen Arazi 2019-09-12 14:39:26 UTC
Created attachment 92730 [details] [review]
Bug 23599: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2019-09-12 14:39:30 UTC
Created attachment 92731 [details] [review]
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Martin Renvoize 2019-09-12 14:58:59 UTC
Created attachment 92733 [details] [review]
Bug 23599: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-09-12 14:59:04 UTC
Created attachment 92734 [details] [review]
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-09-12 15:00:11 UTC
Straight to QA.. works well, fixes the issue.
Comment 6 Martin Renvoize 2019-09-12 15:01:00 UTC
Nice work!

Pushed to master for 19.11.00
Comment 7 Fridolin Somers 2019-09-13 12:54:36 UTC
Depends on Bug 23281 not in 19.05.x