|
Description
Tomás Cohen Arazi (tcohen)
2019-09-16 18:12:44 UTC
Created attachment 92842 [details] [review] Bug 23623: Use the new API for changing privacy settings (guarantors) This patchset makes opac-memberentry.pl use the API instead of the old svc scripts for ajax calls, for setting privacy configuration in the OPAC. To test: 1) Disable OPACPrivacy 2) Enable AllowPatronToSetCheckoutsVisibilityForGuarantor 3) Enable AllowPatronToSetFinesVisibilityForGuarantor 4) Have a known patron be the guarantee of someone (so things display) 5) Log into the OPAC, go to the 'your personal details' tab 6) Change 'Allow your guarantor to view your current checkouts?' and click the 'Update' button. => SUCCESS: Operation succeeds 7) Reload the tab => SUCCESS: The page reflects the expected changes (i.e. the API did it right) 8) Repeat 6 and 7 with the 'Allow your guarantor to view your current fines?' option => SUCCESS: It works as well - Sign off :-D Created attachment 92843 [details] [review] Bug 23623: Remove the svc/patron/show* scripts Created attachment 92914 [details] [review] Bug 23623: Use the new API for changing privacy settings (guarantors) This patchset makes opac-memberentry.pl use the API instead of the old svc scripts for ajax calls, for setting privacy configuration in the OPAC. To test: 1) Disable OPACPrivacy 2) Enable AllowPatronToSetCheckoutsVisibilityForGuarantor 3) Enable AllowPatronToSetFinesVisibilityForGuarantor 4) Have a known patron be the guarantee of someone (so things display) 5) Log into the OPAC, go to the 'your personal details' tab 6) Change 'Allow your guarantor to view your current checkouts?' and click the 'Update' button. => SUCCESS: Operation succeeds 7) Reload the tab => SUCCESS: The page reflects the expected changes (i.e. the API did it right) 8) Repeat 6 and 7 with the 'Allow your guarantor to view your current fines?' option => SUCCESS: It works as well - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 92915 [details] [review] Bug 23623: Remove the svc/patron/show* scripts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 92916 [details] [review] Bug 23623: (follow-up) Add missing comma in ajax call definition Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 92917 [details] [review] Bug 23623: (follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 93001 [details] [review] Bug 23623: Use the new API for changing privacy settings (guarantors) This patchset makes opac-memberentry.pl use the API instead of the old svc scripts for ajax calls, for setting privacy configuration in the OPAC. To test: 1) Disable OPACPrivacy 2) Enable AllowPatronToSetCheckoutsVisibilityForGuarantor 3) Enable AllowPatronToSetFinesVisibilityForGuarantor 4) Have a known patron be the guarantee of someone (so things display) 5) Log into the OPAC, go to the 'your personal details' tab 6) Change 'Allow your guarantor to view your current checkouts?' and click the 'Update' button. => SUCCESS: Operation succeeds 7) Reload the tab => SUCCESS: The page reflects the expected changes (i.e. the API did it right) 8) Repeat 6 and 7 with the 'Allow your guarantor to view your current fines?' option => SUCCESS: It works as well - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 93002 [details] [review] Bug 23623: Remove the svc/patron/show* scripts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 93003 [details] [review] Bug 23623: (follow-up) Add missing comma in ajax call definition Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 93004 [details] [review] Bug 23623: (follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 First use of the REST API in an opac script/template ? |