| Summary: | Remove C4::Logs::GetLogs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
| Circulation function: | |||
| Bug Depends on: | 22363 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 23632: Remove C4::Logs::GetLogs
Bug 23632: Remove C4::Logs::GetLogs Bug 23632: Remove C4::Logs::GetLogs |
||
|
Description
Josef Moravec
2019-09-18 05:16:00 UTC
Created attachment 107871 [details] [review] Bug 23632: Remove C4::Logs::GetLogs Koha::ActionLogs->search must be used instead. There is no call to this subroutine in our code, it should be removed. Test plan: Make sure the 3 test files still return green and that there is no more occurrences of GetLogs in the codebase. Created attachment 107914 [details] [review] Bug 23632: Remove C4::Logs::GetLogs Koha::ActionLogs->search must be used instead. There is no call to this subroutine in our code, it should be removed. Test plan: Make sure the 3 test files still return green and that there is no more occurrences of GetLogs in the codebase. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 108189 [details] [review] Bug 23632: Remove C4::Logs::GetLogs Koha::ActionLogs->search must be used instead. There is no call to this subroutine in our code, it should be removed. Test plan: Make sure the 3 test files still return green and that there is no more occurrences of GetLogs in the codebase. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No brainer, no regressions found and passes QA scripts.. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 enhancement, not backported to 19.11.x |