Bug 23658

Summary: [18.11] WrongTransfer modal drops off specified checkin date on returns.pl
Product: Koha Reporter: Liz Rea <wizzyrea>
Component: CirculationAssignee: Liz Rea (ByWater) <liz>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: bjorn.nylen, gmcharlt, katrin.fischer, kyle.m.hall, lucas, martin.renvoize, nick, wizzyrea
Version: 18.11   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 23658: fix wrong transfer modal dropping specified checkin date
Bug 23658: fix wrong transfer modal dropping specified checkin date
Bug 23658: fix wrong transfer modal dropping specified checkin date

Description Liz Rea 2019-09-20 18:00:07 UTC
To replicate: 

    Have an item that needs a transfer
    use the check in page, and backdate the checkin date
    check in the item, click ok or print - backdating is OK
    Check it in again - backdating drops off
Comment 1 Liz Rea 2019-09-20 18:05:31 UTC
Created attachment 93016 [details] [review]
Bug 23658: fix wrong transfer modal dropping specified checkin date

To test:

Have an item that needs a transfer
use the check in page, and backdate the checkin date
check in the item, click ok or print - backdating is OK
Check it in again - backdating drops off
Apply this patch, restart the things
run tests again, backdating should be retained in all cases.
Comment 2 Liz Rea 2019-09-20 19:08:55 UTC
Note that this is 18.11 only.
Comment 3 Katrin Fischer 2019-09-30 14:01:42 UTC
Created attachment 93262 [details] [review]
Bug 23658: fix wrong transfer modal dropping specified checkin date

To test:

Have an item that needs a transfer
use the check in page, and backdate the checkin date
check in the item, click ok or print - backdating is OK
Check it in again - backdating drops off
Apply this patch, restart the things
run tests again, backdating should be retained in all cases.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Martin Renvoize 2019-10-29 11:16:10 UTC
Created attachment 94825 [details] [review]
Bug 23658: fix wrong transfer modal dropping specified checkin date

To test:

Have an item that needs a transfer
use the check in page, and backdate the checkin date
check in the item, click ok or print - backdating is OK
Check it in again - backdating drops off
Apply this patch, restart the things
run tests again, backdating should be retained in all cases.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-10-29 11:16:26 UTC
Passing QA
Comment 6 Lucas Gass 2019-11-06 17:03:37 UTC
backported to 18.11.x for 18.11.11
Comment 7 Björn Nylén 2020-02-25 12:47:46 UTC
Looks to me that this is in 19.05 as well. We recently upgraded and are experiencing the same issue.