Summary: | Elasticsearch shouldn't throw exception on an uppercase subfield identifier | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicolas Legrand <nicolas.legrand> |
Component: | Searching - Elasticsearch | Assignee: | Nicolas Legrand <nicolas.legrand> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | martin.renvoize, nick, severine.queune |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
Circulation function: | |||
Bug Depends on: | 23670 | ||
Bug Blocks: | |||
Attachments: |
Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier
Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier |
Description
Nicolas Legrand
2019-09-23 16:53:32 UTC
Created attachment 93133 [details] [review] Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Created attachment 93365 [details] [review] Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 93730 [details] [review] Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 |