| Summary: | Elasticsearch - 0 is not a valid boolean for suppress | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Searching - Elasticsearch | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P5 - low | CC: | 1joynelson, black23, jonathan.druart, joonas.kylmala, lucas, marjorie.barry-vila, mkstephens, severine.queune |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 31061 | ||
| Attachments: |
Bug 23676: Use 'false' for opac suppression
Bug 23676: Use 'false' for opac suppression Bug 23676: Use 'false' for opac suppression Bug 23676: Use 'false' for opac suppression |
||
Created attachment 93161 [details] [review] Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed Hello Nick, can you rebase this patch on master? CONFLICT (content): Merge conflict in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23676: Use 'false' for opac suppression Thank you. What log is where the warning goes and which version of elasticsearch do you use? (In reply to Michal Denar from comment #2) > Hello Nick, > can you rebase this patch on master? > > CONFLICT (content): Merge conflict in > Koha/SearchEngine/Elasticsearch/QueryBuilder.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 23676: Use 'false' for opac suppression > > > Thank you. Same as Michal :( Created attachment 95572 [details] [review] Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed (In reply to Joonas Kylmälä from comment #3) > What log is where the warning goes and which version of elasticsearch do you > use? plack-error.log This is in ES 5.x, I think it breaks in 6 Created attachment 96695 [details] [review] Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Patch seemed to work as expected. Test results:
1 - Enabled ES
2 - Enabled OpacSuppression
3 - Suppressed a bib in staff client
Edit 942n to be 1
4 - Searched the opac for keywords related to suppressed record
5 - Tail the plack logs and note a deprecation warning
>> entered command koha-plack-err and watched for warnings; noted deprecation warnings when searching
6 - Applied patch
7 - Restart all the things
>> restart_all, updatedatabase, reindex ES
8 - Repeated search on opac
9 - No error/warn in logs
>> watched koha-plack-err again and no new deprecation warnings appeared after multiple searches
10 - Record is correctly suppressed
>> repeated search in staff client and verified opac suppression
I am using 6.8.3 and OpacSuppression breaks the OPAC search, nothing in the log. This patch fixes the problem! Also it correctly hides the record. Created attachment 97220 [details] [review] Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> *** Bug 23470 has been marked as a duplicate of this bug. *** Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 this patchset has been reverted from 19.05.x as it has been problematic. |
To recreate: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning In a production system these add up fast and can fill the disk