Description
Fridolin Somers
2019-09-26 07:08:07 UTC
Created attachment 93164 [details] [review] Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Created attachment 93165 [details] [review] Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Created attachment 93198 [details] [review] Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 93199 [details] [review] Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 93211 [details] [review] Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 93212 [details] [review] Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 93213 [details] [review] Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 93214 [details] [review] Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Created attachment 93235 [details] [review] Bug 23679: fix software error when trying to transfer an unknown barcode When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. Test plan : 1) Go to /cgi-bin/koha/circ/branchtransfers.pl 2) Enter a barcode not existing in database 3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' 4) Enter a barcode existing in database and check transfer is OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 93236 [details] [review] Bug 23679: add Unit Test t/db_dependent/Circulation/transferbook.t I've choosen to add it to db_dependent because we may add other tests to cover transferbook() cases that will change DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 +my $badbc = 'wherethehelldoyoucomefrom'; Did you see this egg XD Pushed to 19.05.x for 19.05.05 backported to 18.11.x for 18.11.11 |