Bug 23683

Summary:	Course reserves public notes on specific items should allow for HTML
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	OPAC	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	CLOSED FIXED	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	normal
Priority:	P5 - low	CC:	fridolin.somers, lisettepalouse+koha, m.de.rooy
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.11.00,19.05.05
Circulation function:
Attachments:	Bug 23683: Course reserves public notes on specific items should allow for HTML Bug 23683: Course reserves public notes on specific items should allow for HTML Bug 23683: Course reserves public notes on specific items should allow for HTML

Description Lucas Gass (lukeg) 2019-09-26 15:20:10 UTC

BZ22501 allowed librarians to add public notes in HTML to each course but did not allow for the public note on each item in course-items-table to include HTML. Some librarians would like these to also allow for HTML so the can build links. 

A $raw filter should be used on both the OPAC (#course-items-table) AND the staff client (#course_reserves_table).

These notes can only be entered from the staff client so this should be allowable.

Comment 1 Lucas Gass (lukeg) 2019-09-26 15:30:44 UTC

Created attachment 93168 [details] [review]
Bug 23683: Course reserves public notes on specific items should allow for HTML

TEST PLAN:
1. Create A Course Reserve 
2. Add an item to that course and include some HTML in the public note feild.
3. Go to the Course details page in the OPAC and Staff Client and observe the table which includes your reserve item.
4. Notice that it displays HTML literally.
5. Apply Patch and restart_all
6. Visit both the course details page again (staff and OPAC) and notice that the HTML renders.
7. Rejoice!

Comment 2 ByWater Sandboxes 2019-09-26 18:20:39 UTC

Created attachment 93169 [details] [review]
Bug 23683: Course reserves public notes on specific items should allow for HTML

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>

Comment 3 Marcel de Rooy 2019-09-27 09:34:43 UTC

Created attachment 93187 [details] [review]
Bug 23683: Course reserves public notes on specific items should allow for HTML

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Marcel de Rooy 2019-09-27 09:36:27 UTC

With reference to bug 23412 in FQA, Berlin <Germany> does not work. But Alice and Bob are fine ;)

Passed QA

Comment 5 Martin Renvoize (ashimema) 2019-09-27 12:59:51 UTC

Nice work!

Pushed to master for 19.11.00

Comment 6 Fridolin Somers 2019-10-08 07:15:56 UTC

Pushed to 19.05.x for 19.05.05

Comment 7 Fridolin Somers 2019-10-08 07:16:40 UTC

You can see there is just after cr.public_note :
 cr.item.itemnotes | $raw

Comment 8 Lucas Gass (lukeg) 2019-10-17 20:25:48 UTC

backported to 18.11.x for 18.11.11