| Summary: | Terminology: Branches limitations should be libraries limitations - Authorised Values | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, lucas, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.05
|
|
| Circulation function: | |||
| Attachments: |
Bug 23689: Fix terminology for branches limitations on authorized values
Bug 23689: Fix terminology for branches limitations on authorized values Bug 23689: Fix terminology for branches limitations on authorized values Bug 23689: Fix terminology for branches limitations on authorized values Bug 23689: (follow-up) Use Library limitations to match other occurrences |
||
|
Description
Martin Renvoize (ashimema)
2019-09-27 12:50:15 UTC
Created attachment 93206 [details] [review] Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. The patch updates the tooltip to use the bootstrap tooltip but I have no idea how it was displaying a tooltip in the first place and I'm still seeing some markup at the bottom of the page pertaining to the original tooltip implementation. Created attachment 93207 [details] [review] Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Martin Renvoize from comment #2) > The patch updates the tooltip to use the bootstrap tooltip but I have no > idea how it was displaying a tooltip in the first place and I'm still seeing > some markup at the bottom of the page pertaining to the original tooltip > implementation. Ignore that.. the markup I was seeing was inserted by a browser extension. Still, no idea how the original tooltip was working but this does update it to use the same implementation as elsewhere (itemtypes table for instance) Created attachment 93243 [details] [review] Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 93245 [details] [review] Bug 23689: Fix terminology for branches limitations on authorized values This patch corrects the terminology and also updates the tooltip to use the current bootstrap tooltip library. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 93246 [details] [review] Bug 23689: (follow-up) Use Library limitations to match other occurrences Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.05 i cannot clean apply this patchset and I am a bit unsure about my rebase, without a proper test plan I am afraid to backport (In reply to Lucas Gass from comment #10) > i cannot clean apply this patchset and I am a bit unsure about my rebase, > without a proper test plan I am afraid to backport Hi Lucas, this is only a terminology change - I think we can skip it for the late 18.11 versions. |