Description
delaye
2019-09-30 10:24:11 UTC
Created attachment 93443 [details] [review] Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Created attachment 93476 [details] [review] Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> This works fine! Just have a little 'but': For the patron auto-complete we got a system preference to turn the feature off: CircAutocompl So my question would be: Should we also use this pref here? Does it need a pref? I am setting 'Failed QA' - let's discuss this quickly tomorrow. Also adding Owen in CC as he might know about the reasoning behind the pref in circulation. After discussing with Owen, I think it would be best if we use the pref for this as well and update the wording of the pref a little bit to cover both. Matts, could you provide a follow-up please? Any hint on what the syspref should be renamed to? PatronAutoCompl? And why not PatronAutoCompletion, since truncated words are ugly and may me meaningless to some people? (In reply to Matthias Meusburger from comment #5) > Any hint on what the syspref should be renamed to? > > PatronAutoCompl? > > And why not PatronAutoCompletion, since truncated words are ugly and may me > meaningless to some people? I actually meant only correcting the description (although you have a point about it being a bit ugly :) ) Now: [Don't try|Try] to guess the patron being entered while typing a patron search on the circulation screen. Only returns the first 10 results at a time. Maybe change to: [Don't try|Try] to guess the patron being entered while typing a patron search for circulation or patron search. Only returns the first 10 results at a time. How about: [Don't try|Try] to guess the patron when typing a name in the circulation check out and patron search screens. Only shows the first 10 results. Like the idea of making the preference name PatronAutoCompletion. Created attachment 93721 [details] [review] Bug 23697, Follow-up: Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 93738 [details] [review] Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 93739 [details] [review] Bug 23697, Follow-up: Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 93832 [details] [review] Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93833 [details] [review] Bug 23697: (follow-up) Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93834 [details] [review] Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete Just a find and replace on the changed system preference name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93835 [details] [review] Bug 23697: Add autocompletion search in patron module Test plan: - Apply the patch - Go to "Patrons" (members/members-home.pl) - Check that autocomplete is enabled for patron search Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93836 [details] [review] Bug 23697: (follow-up) Add autocompletion search in patron module - Rename CircAutocompl system preference to PatronAutocompletion - Take this system preference into consideration for patron search Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93837 [details] [review] Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete Just a find and replace on the changed system preference name. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 93838 [details] [review] Bug 23697: (QA follow-up) Fix quotes in database update statement Nice work! Pushed to master for 19.11.00 |