| Summary: | Password import explodes when password is too 'weak' and doesn't allow empty passwords anymore | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Tools | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Katrin Fischer
2019-10-03 13:44:01 UTC
Addition: I turned off RequireStrongPassword and tried importing an empty password and it also explodes: Password length (0) is shorter than required (3) at /usr/share/perl5/Exception/Class/Base.pm line 88 There is a use case for importing patrons without a password. Instead of setting some potentially unsafe or unknown default password, you can then have them set their own in the opac using the password reset feature. Should we turn off the password restriction when importing patrons then? I do not create, could you post a example file to test? I do not recreate, could you post a example file to test? I think the real problem is: - Don't check the password if there is a matching patron and system is set to 'don't overwrite' (but that's kind of a strange edge case) - Allow empty passwords We allow empty (no login possible) when adding patrons manually, so this should work for import as well. Sorry, missed the second comment. It appeared when I was testing lately, will check if I still have the file. *** This bug has been marked as a duplicate of bug 23473 *** No, it's not a duplicate. This is about initial import and a regression, the other is a completely new behaviour. I've retested and it seems better now: Initial import (new patrons) cardnumber,surname,userid,categorycode,branchcode,password test1,Mcknight,test1,YA,SPL,'' test2,Edwards,test2,PT,MPL, Patrons are imported, only thing I wonder about: password, userid ! test2 $2a$08$.28krH.OYaHspkZ98mTew.MBDYc4ggbgaxslZgBtmlewQ58Xoip.W test3 What password has been set for the second patron? Overwriting them matching on cardnumber also works as expected. Maybe I was not testing in a clean installation - closing this for now. |