Bug 23751

Summary: Description of staffaccess permission should be improved
Product: Koha Reporter: Ray Delahunty <r.delahunty>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Circulation function:
Attachments: Bug 23751: Make staffaccess permission description more precise
Bug 23751: Make staffaccess permission description more precise
Bug 23751: Make staffaccess permission description more precise

Description Ray Delahunty 2019-10-04 12:47:32 UTC
In Bug 23108 is the comment “A user without the staffaccess permission cannot change the permissions or password for another user belonging to a patron category that is not type Staff. This works as intended.” Both the documentation and the on-screen explanation of this permission makes no mention that this permission is necessary to modify usernames or passwords. May I suggest that the description of the staffaccess permission be changed to read: “Allow staff members to modify permissions and usernames & passwords for other staff members”.
Comment 1 Katrin Fischer 2019-11-02 11:26:00 UTC
This appears fixed in newer versions:
 Allow staff members to modify permissions and passwords for other staff members
Comment 2 Katrin Fischer 2019-11-02 11:26:45 UTC
I realize, there is also username in the mix here. Reopening.
Comment 3 Katrin Fischer 2019-11-02 11:33:08 UTC
Created attachment 94961 [details] [review]
Bug 23751: Make staffaccess permission description more precise

The permission description was missing 'username' from the description.

To test:
- Look at the permissions of a patron
- Verify the staffaccess permission is labelled:
  Allow staff members to modify permissions and passwords for other staff members
- Apply patch
- Check description again:
  Allow staff members to modify permissions, usernames, and passwords for other staff members
Comment 4 Séverine Queune 2019-11-04 10:27:33 UTC
Created attachment 94993 [details] [review]
Bug 23751: Make staffaccess permission description more precise

The permission description was missing 'username' from the description.

To test:
- Look at the permissions of a patron
- Verify the staffaccess permission is labelled:
  Allow staff members to modify permissions and passwords for other staff members
- Apply patch
- Check description again:
  Allow staff members to modify permissions, usernames, and passwords for other staff members

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 5 Jonathan Druart 2019-11-07 11:23:58 UTC
Created attachment 95142 [details] [review]
Bug 23751: Make staffaccess permission description more precise

The permission description was missing 'username' from the description.

To test:
- Look at the permissions of a patron
- Verify the staffaccess permission is labelled:
  Allow staff members to modify permissions and passwords for other staff members
- Apply patch
- Check description again:
  Allow staff members to modify permissions, usernames, and passwords for other staff members

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Martin Renvoize (ashimema) 2019-11-07 13:27:21 UTC
Nice work!

Pushed to master for 19.11.00
Comment 7 Lucas Gass (lukeg) 2019-12-12 00:14:52 UTC
backported to 19.05.x for 19.05.06