Description
Kyle M Hall (khall)
2019-10-09 17:10:07 UTC
Created attachment 93932 [details] [review] Bug 23788: Rename $select to $selected_accts Created attachment 93933 [details] [review] Bug 23788: Rename $select_lines to $selected_lines Created attachment 93934 [details] [review] Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Created attachment 93935 [details] [review] Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Created attachment 93936 [details] [review] Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! sorry this doesnt apply. Created attachment 94276 [details] [review] Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 94277 [details] [review] Bug 23788: Rename $select_lines to $selected_lines Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 94278 [details] [review] Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 94786 [details] [review] Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 94787 [details] [review] Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 94788 [details] [review] Bug 23788: Rename $select_lines to $selected_lines Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 94789 [details] [review] Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Created attachment 95232 [details] [review] Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 95233 [details] [review] Bug 23788: Rename $select_lines to $selected_lines Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 95234 [details] [review] Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Signed-off-by: Sean McGarvey <seanm@pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected and passes qa scripts. Passing QA Nice work! Pushed to master for 19.11.00 |