| Summary: | Allow granular control of social networks enabled by SocialNetworks syspref | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 23791: Allow granular control of social networks enabled by SocialNetworks syspref
Bug 23791: (follow-up) Fix database update description Bug 23791: (follow-up) Add missing CSS changes Bug 23791: (follow-up) Add missing CSS changes Bug 23791: Allow granular control of social networks enabled by SocialNetworks syspref Bug 23791: (follow-up) Fix database update description Bug 23791: (follow-up) Add missing CSS changes |
||
|
Description
Andrew Fuerste-Henry
2019-10-09 22:46:13 UTC
Created attachment 94031 [details] [review] Bug 23791: Allow granular control of social networks enabled by SocialNetworks syspref This patch updates the SocialNetworks system preference so that it offers a choice of social networks (and email) which can be enabled in the OPAC. This patch also replaces the social network images with Font Awesome icons styled so that the colors match the social networks' current branding. The old social networks sprite image is removed. To test, apply the patch and run the database update. Rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client - Go to Administration -> Global system preferences -> OPAC -> Features and find the SocialNetworks preference. - If your SocialNetworks preference was enabled, all choices should be selected. Otherwise none should be selected. - If none are selected, select them all and save. - Locate a record in the OPAC and view the details page. - The social network icons should appear as expected and function as before. - Return to system preferences in the staff client and try enabling and disabling different options, verifying each time that the OPAC reflects your choices. Owen, could you have another look please? Only the Twitter link works for me, the other icons/networks don't show up. yarn build --view opac was run and also multiple restart all... Created attachment 94107 [details] [review] Bug 23791: (follow-up) Fix database update description Created attachment 94375 [details] [review] Bug 23791: (follow-up) Add missing CSS changes This patch adds OPAC CSS changes which were missing from the original patch. It also adds a missing title attribute to the Twitter link. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Follow the previous test plan. Created attachment 94379 [details] [review] Bug 23791: (follow-up) Add missing CSS changes This patch adds OPAC CSS changes which were missing from the original patch. It also adds a missing title attribute to the Twitter link. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Follow the previous test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 94380 [details] [review] Bug 23791: Allow granular control of social networks enabled by SocialNetworks syspref This patch updates the SocialNetworks system preference so that it offers a choice of social networks (and email) which can be enabled in the OPAC. This patch also replaces the social network images with Font Awesome icons styled so that the colors match the social networks' current branding. The old social networks sprite image is removed. To test, apply the patch and run the database update. Rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client - Go to Administration -> Global system preferences -> OPAC -> Features and find the SocialNetworks preference. - If your SocialNetworks preference was enabled, all choices should be selected. Otherwise none should be selected. - If none are selected, select them all and save. - Locate a record in the OPAC and view the details page. - The social network icons should appear as expected and function as before. - Return to system preferences in the staff client and try enabling and disabling different options, verifying each time that the OPAC reflects your choices. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 94381 [details] [review] Bug 23791: (follow-up) Fix database update description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 94382 [details] [review] Bug 23791: (follow-up) Add missing CSS changes This patch adds OPAC CSS changes which were missing from the original patch. It also adds a missing title attribute to the Twitter link. To test, apply the patch and regenerate the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Follow the previous test plan. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 |