| Summary: | Convert OpacCredits system preference to news block | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Alex Arnaud <alex.arnaud> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, alex.arnaud, bgkriegel, lucas, sally.healey, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 22318, 22880 | ||
| Bug Blocks: | 26050 | ||
| Attachments: |
Bug 23794: Convert opaccredits system preference to news block
Bug 23795: Convert opaccredits system preference to news block Bug 23795: Convert opaccredits system preference to news block Bug 23795: Convert opaccredits system preference to news block Bug 23795: Convert opaccredits system preference to news block Bug 23795: Convert opaccredits system preference to news block |
||
|
Description
Owen Leonard
2019-10-10 18:38:36 UTC
Created attachment 99706 [details] [review] Bug 23794: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Hi Owen, patch works ok, but: * Commit message references Bug 23794 instead of 23795 (easy) * QA tools complains FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template koha_news_block: not found Created attachment 101581 [details] [review] Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Created attachment 101696 [details] [review] Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> I tested this on a sandbox and it works for the English language. I couldn't find an option to install alternative languages on the newer sandbox environments. I attempted to test on Biblibre's sandboxes which allow alternative languages. I couldn't find a way to add content to the opaccredits and then add the patch to test if the content carries over. However, I can confirm that the other language drop downs are visible in the news section if the patch is applied. I've added my sign off, but I understand how important additional languages are. Another person may want to test on a dev environment to double check? Comment on attachment 101696 [details] [review] Bug 23795: Convert opaccredits system preference to news block Review of attachment 101696 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ +9,1 @@ > [% UNLESS ( is_popup ) %] I don't understand why the html_helpers block is added here. I understand even less why it is added twice. This patch needs a very tiny rebase also Created attachment 106102 [details] [review] Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 106103 [details] [review] Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 106104 [details] [review] Bug 23795: Convert opaccredits system preference to news block This patch builds on Bug 22318 to move the opaccredits system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the opaccredits system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the opaccredits system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from opaccredits is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'opaccredits_en', 'opaccredits_fr-FR', 'opaccredits_cs-CZ' - Go to Administration -> System preferences and confirm that the opaccredits preference has been removed. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Pushed to master for 20.11, thanks to everybody involved! choosing to backport these HTML -> News enhancements to 20.05.x backpoted to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x |