| Summary: | Convert OpacCustomSearch system preference to news block | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, caroline.cyr-la-rose, claudie.tregouet, jonathan.druart, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 22318, 22880, 24745 | ||
| Bug Blocks: | 26050, 26810 | ||
| Attachments: |
Bug 23796: Convert OpacCustomSearch system preference to news block
Bug 23796: Convert OpacCustomSearch system preference to news block Bug 23796: Convert OpacCustomSearch system preference to news block Bug 23796: Convert OpacCustomSearch system preference to news block |
||
|
Description
Owen Leonard
2019-10-10 18:39:52 UTC
Created attachment 99711 [details] [review] Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. I've tried to apply this patch but I've got an error. I paste what I've got here : Bug 23796 - Convert OpacCustomSearch system preference to news block 99711 - Bug 23796: Convert OpacCustomSearch system preference to news block Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23796: Convert OpacCustomSearch system preference to news block error: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). error: could not build fake ancestor Patch failed at 0001 Bug 23796: Convert OpacCustomSearch system preference to news block The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23796-Convert-OpacCustomSearch-system-preferen-30tSIU.patch Created attachment 103160 [details] [review] Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Created attachment 103324 [details] [review] Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Created attachment 106620 [details] [review] Bug 23796: Convert OpacCustomSearch system preference to news block This patch moves the OpacCustomSearch system preference into the Koha news system, making it possible to have language- and library-specific content. To test you should have some content in the OpacCustomSearch system preference. Apply the patch and run the database update process. - Go to the OPAC and confirm that the content which was previously in the OpacCustomSearch system preference now displays correctly where it was before. - In the staff client, go to Tools -> News and verify that the content from OpacCustomSearch is now stored in news items. There should be one entry for each of the enabled translations in your system, for instance 'OpacCustomSearch_en', 'OpacCustomSearch_fr-FR', 'OpacCustomSearch_cs-CZ' - Go to Administration -> System preferences and confirm that the OpacCustomSearch preference has been removed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Owen, what is the purpose of the "blocktitle" param in the TT plugin? Looks like it's not needed. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x I'm trying to add new content through the news tool, but I'm not able to... 1) Go to Tools > News 2) Add a new news item with display location set to OpacCustomSearch(en) (I put <h1>OpacCustomSearch</h1> in mine) 3) Go to OPAC and refresh (or restart plack or memcached or something) Here, I'm not seeing <h1>OpacCustomSearch</h1> anywhere Is anyone able to add new content? Nick filed bug 26810 |