Bug 23806

Summary: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
Product: Koha Reporter: Kyle M Hall <kyle>
Component: CirculationAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, lucas
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 23228    
Bug Blocks:    
Attachments: Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button

Description Kyle M Hall 2019-10-11 16:06:13 UTC
FinePaymentAutoPopup works correctly for payments by amount, but do not for the "Write off" button that appears on each fee line.
Comment 1 Kyle M Hall 2019-10-11 16:11:11 UTC
Created attachment 94025 [details] [review]
Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button
Comment 2 Kyle M Hall 2019-10-16 11:49:21 UTC
Created attachment 94273 [details] [review]
Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button

Test Plan:
1) Enable reciept popups for payments and writeoffs
2) Test the "Write off" button, no popup
3) Apply this patch
4) Restart all the things!
5) Test again, you should get the popup!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 3 Jonathan Druart 2019-11-07 12:53:08 UTC
Created attachment 95153 [details] [review]
Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button

Test Plan:
1) Enable reciept popups for payments and writeoffs
2) Test the "Write off" button, no popup
3) Apply this patch
4) Restart all the things!
5) Test again, you should get the popup!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Martin Renvoize 2019-11-07 13:27:28 UTC
Nice work!

Pushed to master for 19.11.00
Comment 5 Lucas Gass 2019-12-16 22:12:41 UTC
missing dependencies for 19.05.x, no backport