Bug 23834

Summary: Add default ESLint configuration
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, testopia
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on:    
Bug Blocks: 23833    
Attachments: Bug 23834: Add default ESLint configuration
Bug 23834: Add default ESLint configuration

Description Owen Leonard 2019-10-17 13:38:21 UTC
Default configuration proposed when the ESLint coding guideline was voted on:

{
    "env": {
        "browser": true,
        "jquery": true
    },
    "extends": "eslint:recommended",
    "rules": {
        "indent": [
            "error",
            4
        ],
        "linebreak-style": [
            "error",
            "unix"
        ],
        "semi": [
            "error",
            "always"
        ]
    }
}
Comment 1 Owen Leonard 2019-10-17 13:51:14 UTC
Created attachment 94373 [details] [review]
Bug 23834: Add default ESLint configuration

This patch adds a default ESLint configuration for use when editing
JavaScript, as recommended in the coding guidelines:

https://wiki.koha-community.org/wiki/Coding_Guidelines#JS8:_Follow_guidelines_set_by_ESLint
Comment 2 Katrin Fischer 2019-11-02 13:57:22 UTC
Created attachment 94966 [details] [review]
Bug 23834: Add default ESLint configuration

This patch adds a default ESLint configuration for use when editing
JavaScript, as recommended in the coding guidelines:

https://wiki.koha-community.org/wiki/Coding_Guidelines#JS8:_Follow_guidelines_set_by_ESLint

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2019-11-02 13:57:47 UTC
Adds a config file, PQA right away.
Comment 4 Martin Renvoize 2019-11-03 08:12:23 UTC
Nice work!

Pushed to master for 19.11.00