| Summary: | tracklinks.pl should not forward if TrackClicks is disabled | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas, m.de.rooy, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 23329 | ||
| Bug Blocks: | 24144 | ||
| Attachments: |
Bug 23836: Don't forward form tracklinks if not tracking
Bug 23836: Don't forward form tracklinks if not tracking Bug 23836: exit after output_error Bug 23836: Don't forward form tracklinks if not tracking Bug 23836: exit after output_error |
||
|
Description
Nick Clemens (kidclamp)
2019-10-17 15:25:39 UTC
Created attachment 94376 [details] [review] Bug 23836: Don't forward form tracklinks if not tracking Created attachment 94872 [details] [review] Bug 23836: Don't forward form tracklinks if not tracking Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 94873 [details] [review] Bug 23836: exit after output_error Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Looks like Koha::Linktracker->new should return undef if the pref is not set, but... TODO LATER. Created attachment 94935 [details] [review] Bug 23836: Don't forward form tracklinks if not tracking Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 94936 [details] [review] Bug 23836: exit after output_error Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> this is applied to the 18.11.x security branch for 18.11.11 Nice work! Pushed to master for 19.11.00 We were pretty bad here guys, tests have not been adjusted. |