Summary: | Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | eb, gmcharlt, hc, jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
19.11.00
|
Circulation function: | |
Attachments: |
Bug 23847: Fix custom item search fields if subfield is '0'
Bug 23847: Fix custom item search fields if subfield is '0' Bug 23847: Fix custom item search fields if subfield is '0' |
Description
Katrin Fischer
2019-10-21 06:16:58 UTC
It's a 0 vs undefined coding error in the template. Patch is coming. Created attachment 94423 [details] [review] Bug 23847: Fix custom item search fields if subfield is '0' The subfield is not used if is false, so if 0. We want to test if the subfield is defined and not an empty string. Test plan: - Define a new custom item search fields using a subfield '0' (withdrawn=952$0 for instance) - Define one which does not have a subfield (control field) - Search items using those newly created fields. Thx Jonathan! Created attachment 94983 [details] [review] Bug 23847: Fix custom item search fields if subfield is '0' The subfield is not used if is false, so if 0. We want to test if the subfield is defined and not an empty string. Test plan: - Define a new custom item search fields using a subfield '0' (withdrawn=952$0 for instance) - Define one which does not have a subfield (control field) - Search items using those newly created fields. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Confusing title and test plan. Just figured out how to reproduce by searching on withdrawn in the box below instead of the withdrawn field above it. Created attachment 95194 [details] [review] Bug 23847: Fix custom item search fields if subfield is '0' The subfield is not used if is false, so if 0. We want to test if the subfield is defined and not an empty string. Test plan: - Define a new custom item search fields using a subfield '0' (withdrawn=952$0 for instance) - Define one which does not have a subfield (control field) - Search items using those newly created fields. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 |