|
Description
Owen Leonard
2019-10-21 13:09:54 UTC
Created attachment 94455 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Created attachment 98770 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Hi Owen. Just checking on this one before I sign it off. There are several areas where, while they reflect current behaviour, are inconsistent. I'm assuming this bug is 'like for like' and that any corrections to address inconsistencies should be a separate bug. Examples include: - Home › Circulation › Checkouts <-- Checkouts is in bold, should possibly be Check out (to match with other buttons and labels) - Home › Circulation › Checkouts › [Patron name (ID)] <-- should possibly be Check out rather than Checkouts (after putting in a patron) - For several items the last part of the breadcrumb is linked: . Home › Circulation › Article requests . Home › Circulation › Holds queue . Home › Circulation › Holds awaiting pickup . Home › Circulation › Set library . Home › Tools › Batch record deletion - Other things noticed: . Home › Circulation › Transfers <-- Button on the circulation page is Transfer, although it does have a group heading Transfers . Home › Circulation › Overdues at [Library name] <-- For Overdues with fines, should this display as Overdues with fines at [Library name] instead? Notes for myself from testing - enable these system preferences: - StockRotation (enable) - ArticleRequests (enable) - BatchCheckouts (allow) + BatchCheckoutsValidCategories (add patron categories) Created attachment 106879 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Patch no longer applies 8-( Created attachment 109687 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Created attachment 109702 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Hm, with the patch applied the title of a record in the result list suddenly appears italic, is this intentional? Created attachment 110055 [details] [review] Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Created attachment 110128 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110129 [details] [review] Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Does no longer apply, please rebase. Created attachment 111134 [details] [review] Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 111135 [details] [review] Bug 23852: Merge biblio-title.inc and biblio-default-view.inc This patch moves the functionality contained in biblio-default-view.inc into biblio-title.inc. biblio-title.inc can now be called with a "link = 1" parameter in order for the title to be displayed as a link which is controlled by the IntranetBiblioDefaultView preference. To test, apply the patch and test the affected pages, especially titles linked to in breadcrumbs menus Acquisitions: - Add to basket -> From existing record -> Search - Title in search results Catalog: - Search for a record - Add record to cart - Open cart - Title in brief display - Check that link opens the correct page in the main window - View bibliographic record - ISBD view - MARC view - Normal view - Local cover image detail page - Checkout history - Request article - Item details - From the "Edit" menu -> Attach item - Stock rotation rota - Place hold Cataloging: - Cataloging search -> Search results Circulation: - Article requests - Overdues with fines - Overdues - Holds queue - Holds to pull - Hold ratios - Holds awaiting pickup - Transfers to recevie - Renew - Batch checkout Lists: - View list contents Patrons: - View patron details - Holds history - Checkout history Tools: - Rotating collections - View collection - Add item - Tags - Click term to see titles tagged with that term - Batch record deletion - Submit batch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 111136 [details] [review] Bug 23852: (QA follow-up) Correct scope of breadcrumb title style This patch corrects the scope of the ".title" style intended for titles displayed in the breadcrumbs bar. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! Created attachment 111393 [details] [review] Bug 23852: (QA follow-up) Fix remaining call to biblio-default-view (In reply to Nick Clemens from comment #17) > Created attachment 111393 [details] [review] [review] > Bug 23852: (QA follow-up) Fix remaining call to biblio-default-view This patch has ben pushed to master on Oct 9. enhancement will not be backported to 20.05.x |