Bug 23860

Summary: Patrons endpoint not setting the Location header
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: REST APIAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: martin.renvoize, tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 23843    
Bug Blocks:    
Attachments: Bug 23860: Regression tests
Bug 23860: Make the patrons endpoint add the Location header
Bug 23860: Update tests to new style
Bug 23860: Regression tests
Bug 23860: Make the patrons endpoint add the Location header
Bug 23860: Update tests to new style

Description Tomás Cohen Arazi 2019-10-21 19:17:04 UTC

    
Comment 1 Tomás Cohen Arazi 2019-10-22 16:57:51 UTC
Created attachment 94583 [details] [review]
Bug 23860: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2019-10-22 16:57:54 UTC
Created attachment 94584 [details] [review]
Bug 23860: Make the patrons endpoint add the Location header

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2019-10-22 16:57:59 UTC
Created attachment 94585 [details] [review]
Bug 23860: Update tests to new style

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Martin Renvoize 2019-11-01 08:45:53 UTC
Created attachment 94941 [details] [review]
Bug 23860: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-11-01 08:45:57 UTC
Created attachment 94942 [details] [review]
Bug 23860: Make the patrons endpoint add the Location header

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2019-11-01 08:46:00 UTC
Created attachment 94943 [details] [review]
Bug 23860: Update tests to new style

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2019-11-01 08:46:48 UTC
Trivial patch that improves the consistency of our API's.

Passing QA
Comment 8 Martin Renvoize 2019-11-01 08:49:03 UTC
Nice work!

Pushed to master for 19.11.00