Summary: | sip_cli_emulator.pl - typo in parameter name | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
Component: | Command-line Utilities | Assignee: | Bugs List <koha-bugs> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | colin.campbell, jonathan.druart, joonas.kylmala, katrin.fischer, kyle, martin.renvoize, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 13159 | ||
Bug Blocks: | |||
Attachments: |
Bug 23883: SIP - Fix typo in parameter name
Bug 23883: SIP - Fix typo in parameter name |
Description
Andrew Isherwood
2019-10-23 10:33:33 UTC
Created attachment 96374 [details] [review] Bug 23883: SIP - Fix typo in parameter name The options of the script have hypens whereas the hash keys have underscore. In my understanding the problem only occurs on display purpose. Test plan: Try a sip command like % perl misc/sip_cli_emulator.pl -a localhost -su term1 -sp term1 -l CPL -m fee_paid Without this patch you will see: fee_amount is required for fee_paid With this patch the correct option is listed: fee-amount is required for fee_paid Created attachment 96382 [details] [review] Bug 23883: SIP - Fix typo in parameter name The options of the script have hypens whereas the hash keys have underscore. In my understanding the problem only occurs on display purpose. Test plan: Try a sip command like % perl misc/sip_cli_emulator.pl -a localhost -su term1 -sp term1 -l CPL -m fee_paid Without this patch you will see: fee_amount is required for fee_paid With this patch the correct option is listed: fee-amount is required for fee_paid Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Well, this same issue happens if you don't specify the --patron parameter:
> patron_identifier is required for fee_paid
Here if instead of --patron you try --patron-identifier (patron_identifier with hyphen instead) it doesn't work. So the proposed fix doesn't really solve this problem but only the specific case of --fee-amount parameter.
Maybe that should be moved one line above, but I am not sure how to test that correctly actually. diff --git a/misc/sip_cli_emulator.pl b/misc/sip_cli_emulator.pl index 1b987279b5..f28c067674 100755 --- a/misc/sip_cli_emulator.pl +++ b/misc/sip_cli_emulator.pl @@ -319,8 +319,8 @@ sub build_command_message { foreach my $key ( keys %$parameters ) { unless ( $parameters->{$key} ) { + $key =~ s|_|-|g; # options of this script have hyphens unless ( $optional{$key} ) { - $key =~ s|_|-|g; # options of this script have hyphens say "$key is required for $message"; return; } |