| Summary: | Merge strings.inc and browser-strings.inc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, ere.maijala |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 23884: Merge strings.inc and browser-strings.inc
Bug 23884: Merge strings.inc and browser-strings.inc Bug 23884: Merge strings.inc and browser-strings.inc Bug 23884: Merge strings.inc and browser-strings.inc |
||
|
Description
Owen Leonard
2019-10-23 12:00:32 UTC
Created attachment 94615 [details] [review] Bug 23884: Merge strings.inc and browser-strings.inc This patch take the contents of the JavaScript in browser-strings.inc and puts it in strings.inc. browser-strings.inc is deleted. To test, apply the patch and perform a catalog search in the staff client. - View any result. In the left-hand sidebar there should be a search results browser box with "previous" and "next" arrows and a link back to search results. - Click on each different "view" tab and confirm that the search results navigation box persists: Normal, MARC, Labeled MARC, ISBD, Items. - From any of these views select Edit -> Edit items. The same navigation box should appear. Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't currently work on those pages. Created attachment 97659 [details] [review] Bug 23884: Merge strings.inc and browser-strings.inc This patch take the contents of the JavaScript in browser-strings.inc and puts it in strings.inc. browser-strings.inc is deleted. To test, apply the patch and perform a catalog search in the staff client. - View any result. In the left-hand sidebar there should be a search results browser box with "previous" and "next" arrows and a link back to search results. - Click on each different "view" tab and confirm that the search results navigation box persists: Normal, MARC, Labeled MARC, ISBD, Items. - From any of these views select Edit -> Edit items. The same navigation box should appear. Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't currently work on those pages. Rebased. Created attachment 97682 [details] [review] Bug 23884: Merge strings.inc and browser-strings.inc This patch take the contents of the JavaScript in browser-strings.inc and puts it in strings.inc. browser-strings.inc is deleted. To test, apply the patch and perform a catalog search in the staff client. - View any result. In the left-hand sidebar there should be a search results browser box with "previous" and "next" arrows and a link back to search results. - Click on each different "view" tab and confirm that the search results navigation box persists: Normal, MARC, Labeled MARC, ISBD, Items. - From any of these views select Edit -> Edit items. The same navigation box should appear. Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't currently work on those pages. Signed-off-by: David Nind <david@davidnind.com> Created attachment 97698 [details] [review] Bug 23884: Merge strings.inc and browser-strings.inc This patch take the contents of the JavaScript in browser-strings.inc and puts it in strings.inc. browser-strings.inc is deleted. To test, apply the patch and perform a catalog search in the staff client. - View any result. In the left-hand sidebar there should be a search results browser box with "previous" and "next" arrows and a link back to search results. - Click on each different "view" tab and confirm that the search results navigation box persists: Normal, MARC, Labeled MARC, ISBD, Items. - From any of these views select Edit -> Edit items. The same navigation box should appear. Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't currently work on those pages. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11.x |