| Summary: | Improve style of menu header in advanced cataloging editor | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, hayleypelham, jonathan.druart, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement updates the styling of dropdown menu headers to make them apply more consistently across the system.
|
Version(s) released in: |
20.05.00, 19.11.02
|
| Circulation function: | |||
| Attachments: |
GIF comparing before and after the patch
Bug 23889: Improve style of menu header in advanced cataloging editor Bug 23889: Improve style of menu header in advanced cataloging editor Bug 23889: Improve style of menu header in advanced cataloging editor Bug 23889: Use same css class on the basic editor view |
||
Created attachment 94679 [details] [review] Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Created attachment 94977 [details] [review] Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> What I see is different from what you advertised: https://snipboard.io/X4UwbT.jpg (In reply to Jonathan Druart from comment #3) > What I see is different from what you advertised: > https://snipboard.io/X4UwbT.jpg Hum ignore that, I got an error on `yarn build` that I did not see! Created attachment 96337 [details] [review] Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 96338 [details] [review] Bug 23889: Use same css class on the basic editor view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #6) > Created attachment 96338 [details] [review] [review] > Bug 23889: Use same css class on the basic editor view > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Owen, can you confirm you agree with this patch please? Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 backported to 19.05.x. for 19.05.07 Enhancement will not be backported to 18.11.x series. |
Created attachment 94677 [details] GIF comparing before and after the patch The "Settings" menu in the advanced cataloging editor has a menu item which is a header (change framework). This should be styled better, matching, for instance, the "Sort" menu on catalog search results.