Description
Marcel de Rooy
2019-10-25 08:48:08 UTC
Will add a test for it, but building it on top of work in 21190 Created attachment 94719 [details] [review] Bug 23896: logaction should pass the correct interface to Koha::Logger Trivial fix. Test plan: Run t/db../Log.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 94720 [details] [review] Bug 23896: Add unit tests Test plan: Run t/db_dependent/Log.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #1) > Will add a test for it, but building it on top of work in 21190 Well, I think I skip a test here. We need to mock AUTOLOAD in Koha::Logger and similar horrible stuff to just check a trivial parameter. Out of balance. No test is just easier. Created attachment 94721 [details] [review] Bug 23896: logaction should pass the correct interface to Koha::Logger Trivial fix. Test plan: Run t/db../Log.t to ensure that we did not break stuff. If you set opac to debug in log4perl config, inspect opac-error.log to see if you have extra loglines from running the test script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> This is a trivial oneliner patch and I waited three months for a signoff without any response. Taking the liberty to switch it to Signed off myself. Please cover this change with a test :) Created attachment 98080 [details] [review] Bug 23896: logaction should pass the correct interface to Koha::Logger Trivial fix. Test plan: Run t/db../Log.t to ensure that we did not break stuff. If you set opac to debug in log4perl config, inspect opac-error.log to see if you have extra loglines from running the test script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Jonathan Druart from comment #7) > Please cover this change with a test :) IRC: [14:36] <marcelr> did you see comment4 on the report btw? it justifies the absence of a test [14:37] <marcelr> i considered it as out of balance Created attachment 98085 [details] [review] Bug 23896: logaction should pass the correct interface to Koha::Logger Trivial fix. Test plan: Run t/db../Log.t to ensure that we did not break stuff. If you set opac to debug in log4perl config, inspect opac-error.log to see if you have extra loglines from running the test script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.03 backported to 19.05.x for 19.05.08 Backported to 18.11.x for 18.11.14. |