Summary: | Fix js error sms_input is null in opac-messaging.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
Component: | OPAC | Assignee: | Lari Taskula <lari.taskula> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
Circulation function: | |||
Bug Depends on: | 22862 | ||
Bug Blocks: | |||
Attachments: |
Bug 23901: Fix sms_input is null in opac-messaging.tt
Bug 23901: Fix indentation Bug 23901: Fix sms_input is null in opac-messaging.tt Bug 23901: Fix indentation Bug 23901: Fix sms_input is null in opac-messaging.tt Bug 23901: Fix indentation |
Description
Lari Taskula
2019-10-25 13:35:54 UTC
Created attachment 94767 [details] [review] Bug 23901: Fix sms_input is null in opac-messaging.tt When sms messaging is disabled, JavaScript breaks on opac-messaging.tt. Bug introduced in Bug 22862. To test: 1. Enable EnhancedMessagingPreferences system preference 2. Disable sms messaging by unsetting SMSSendDriver system preference 3. Go to OPAC -> your messaging 4. Observe JavaScript error "sms_input is null" in your browser console 5. Apply patch 6. Refresh page and observe the error is gone Created attachment 94768 [details] [review] Bug 23901: Fix indentation This patch only fixes the indentation of code inside the if-block. Created attachment 94769 [details] [review] Bug 23901: Fix sms_input is null in opac-messaging.tt When sms messaging is disabled, JavaScript breaks in opac-messaging.tt. Bug introduced in Bug 22862. To test: 1. Enable EnhancedMessagingPreferences system preference 2. Disable sms messaging by unsetting SMSSendDriver system preference 3. Go to OPAC -> your messaging 4. Observe JavaScript error "sms_input is null" in your browser console 5. Apply patch 6. Refresh page and observe the error is gone Sponsored-by: Koha-Suomi Oy Created attachment 94770 [details] [review] Bug 23901: Fix indentation This patch only fixes the indentation of code inside the if-block. To test: 1. Apply patch 2. Run: git diff -w HEAD~1 and observe no result Sponsored-by: Koha-Suomi Oy Created attachment 95762 [details] [review] Bug 23901: Fix sms_input is null in opac-messaging.tt When sms messaging is disabled, JavaScript breaks in opac-messaging.tt. Bug introduced in Bug 22862. To test: 1. Enable EnhancedMessagingPreferences system preference 2. Disable sms messaging by unsetting SMSSendDriver system preference 3. Go to OPAC -> your messaging 4. Observe JavaScript error "sms_input is null" in your browser console 5. Apply patch 6. Refresh page and observe the error is gone Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 95763 [details] [review] Bug 23901: Fix indentation This patch only fixes the indentation of code inside the if-block. To test: 1. Apply patch 2. Run: git diff -w HEAD~1 and observe no result Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Simple change, passing QA too. Nice work! Pushed to master for 19.11.00 |