Summary: | Replace OPAC list sort menu with Bootstrap menu button | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, david, lucas, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display.
|
Version(s) released in: |
20.05.00
|
Bug Depends on: | 23913 | ||
Bug Blocks: | 24996 | ||
Attachments: |
Screenshot showing the new menu button (in its active state)
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button Bug 23915: Replace OPAC list sort menu with Bootstrap menu button Bug 23915: Replace OPAC list sort menu with Bootstrap menu button Bug 23915: Replace OPAC list sort menu with Bootstrap menu button Bug 23915: Replace OPAC list sort menu with Bootstrap menu button |
Description
Owen Leonard
2019-10-28 17:49:44 UTC
Created attachment 94817 [details] [review] Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. Owen, This is by far better than the old form! I have two comments: 1. When you pull up the new dropdown I think the .dropdown-header classes look a bit off. Can the text be bold and can we include a margin-left so the text isn't right up against the dropdown. 2. On smaller mobile screens #toolbar disappears entirely eliminating the ability to sort from a phone or small screen size. (This is at 600px and below). Error message when applying patch - I think this means the patch didn't apply: Applying: Bug 23915: Replace OPAC list sort menu with Bootstrap menu button error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23915: Replace OPAC list sort menu with Bootstrap menu button The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23915-Replace-OPAC-list-sort-menu-with-Bootstr-dRZj3P.patch Created attachment 97975 [details] [review] Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. Everything looks and works fine except for the sort by copyright date. - Copyright date (newest to oldest): sorts as asc when it should be desc (for example, lists an 1875 item before 2009) - Copyright date (oldest to newest): sorts as desc when it should be asc (for example, lists an 2009 item before 1875) It looks like this was introduced by Bug 23913 - the above behaviour is in master, but not in 19.11.x. Should this be fixed in this bug, or should it be a new bug? Created attachment 98039 [details] [review] Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. (In reply to David Nind from comment #5) > Should this be fixed in this bug, or should it be a new bug? I have modified the patch. Created attachment 98045 [details] [review] Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. Signed-off-by: David Nind <david@davidnind.com> Created attachment 98092 [details] [review] Bug 23915: Replace OPAC list sort menu with Bootstrap menu button This patch adds JavaScript to the list contents page which converts the resort form's <select> menu into a Bootstrap dropdown menu. This allows for a more compact and consistent display. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View a list in the OPAC. The toolbar of list controls ("New list," "Download list," etc.) should have a similary-styled "Sort" button. Each sorting option should work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11.x |