Bug 23934

Summary: Item level holds not checked for LocalHoldsPriority in Holds Queue
Product: Koha Reporter: Nick Clemens <nick>
Component: Hold requestsAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: 1joynelson, andrewfh, gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00, 19.11.03
Bug Depends on: 18001    
Bug Blocks: 25786    
Attachments: Bug 23934: Unit test
Bug 23934: Unit test
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue
Bug 23934: Unit test
Bug 23934: Unit test
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue
Bug 23934: Unit test
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue

Description Nick Clemens 2019-10-31 12:16:24 UTC

    
Comment 1 Nick Clemens 2019-10-31 12:17:35 UTC
Created attachment 94908 [details] [review]
Bug 23934: Unit test
Comment 2 Kyle M Hall 2019-10-31 17:54:29 UTC
Created attachment 94923 [details] [review]
Bug 23934: Unit test
Comment 3 Kyle M Hall 2019-10-31 17:54:40 UTC
Created attachment 94924 [details] [review]
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue
Comment 4 Kyle M Hall 2019-10-31 18:24:12 UTC
Created attachment 94926 [details] [review]
Bug 23934: Unit test
Comment 5 Kyle M Hall 2019-10-31 18:27:30 UTC
Created attachment 94929 [details] [review]
Bug 23934: Unit test
Comment 6 Kyle M Hall 2019-10-31 18:27:45 UTC
Created attachment 94930 [details] [review]
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue
Comment 7 Andrew Fuerste-Henry 2019-12-10 14:39:58 UTC
Test plan:
- Set LocalHoldsPriority to "Give priority for filling holds to patrons whose pickup library matches the item's holding library"
- set yourself at Library A
- find at item at Library A
- place an item-level hold (Hold 1) for item for pickup at Library B
- set an item-level hold (Hold 2) for item for pickup at Library A
- Confirm Hold 1 shows priority=1
- Check in item
- confirm item would be captured for Hold 2, ignore hold
- run holds queue
- check item in
- confirm item is captured for Hold 2
Comment 8 ByWater Sandboxes 2019-12-10 15:10:15 UTC
Created attachment 96163 [details] [review]
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 9 Jonathan Druart 2020-01-10 13:05:38 UTC
Created attachment 97196 [details] [review]
Bug 23934: Unit test

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2020-01-10 13:05:42 UTC
Created attachment 97197 [details] [review]
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue

Test plan:
- Set LocalHoldsPriority to "Give priority for filling holds to patrons
whose pickup library matches the item's holding library"
- set yourself at Library A
- find at item at Library A
- place an item-level hold (Hold 1) for item for pickup at Library B
- set an item-level hold (Hold 2) for item for pickup at Library A
- Confirm Hold 1 shows priority=1
- Check in item
- confirm item would be captured for Hold 2, ignore hold
- run holds queue
- check item in
- confirm item is captured for Hold 2

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Martin Renvoize 2020-01-10 16:23:36 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 12 Joy Nelson 2020-01-31 00:20:00 UTC
Pushed to 19.11.x branch for 19.11.03
Comment 13 Lucas Gass 2020-02-06 15:20:51 UTC
unit tests do not apply cleanly to 19.05.x branch, no backport