Bug 23939

Summary: Title missing from Checked out box
Product: Koha Reporter: Kelly McElligott <kelly>
Component: CirculationAssignee: Nick Clemens (kidclamp) <nick>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, lisette, philippe.blouin
Version: 19.05   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 23939 - Invoice adjustments should filter inactive funds

Description Kelly McElligott 2019-10-31 18:56:20 UTC
In 19.05, the small checked-out box (circulation.tt) that usually displays the title, barcode and due date (as a quick look at what the library is checking out to the patron), SEE SCREENSHOT.  This is now only showing barcode and date due. Can we resolve and get the title to display again.
Comment 1 Lisette Scheer 2019-10-31 18:58:47 UTC

*** This bug has been marked as a duplicate of bug 23938 ***
Comment 2 Blou 2021-01-26 20:51:31 UTC
Created attachment 115835 [details] [review]
Bug 23939 - Invoice adjustments should filter inactive funds

Looking at invoice details, this makes the Adjustments Fund dropdown act
exactly like the Shipping Fund dropdown above, with a Show inactive
checkbox to help filter (by default) the inactive funds out of the list.

Test plan:
0) requires a database with inactive (old) funds along with active ones.
1) Go to invoice details page
2) Click "Add adjustment"
3) Open the drop down beside the Fund label, you should see EVERY fund in database.
4) Compare with behavior of Shipping fund dropdown above.  Not every fund is listed there
5) Apply patch
6) Now behavior is the same, only active fund are listed by default.
7) click "Show inactive" checkbox and see all the funds in the dropdown.
Comment 3 Blou 2021-01-26 20:52:18 UTC
wrong BZ id, my apologies.
Comment 4 Blou 2021-01-26 20:52:39 UTC
Comment on attachment 115835 [details] [review]
Bug 23939 - Invoice adjustments should filter inactive funds

>From 62ec8d38bdb5778ffc015344fb2d0274476bd1cb Mon Sep 17 00:00:00 2001
>From: Blou <blou@inlibro.com>
>Date: Tue, 26 Jan 2021 15:36:31 -0500
>Subject: [PATCH] Bug 23939 - Invoice adjustments should filter inactive funds
>
>Looking at invoice details, this makes the Adjustments Fund dropdown act
>exactly like the Shipping Fund dropdown above, with a Show inactive
>checkbox to help filter (by default) the inactive funds out of the list.
>
>Test plan:
>0) requires a database with inactive (old) funds along with active ones.
>1) Go to invoice details page
>2) Click "Add adjustment"
>3) Open the drop down beside the Fund label, you should see EVERY fund in database.
>4) Compare with behavior of Shipping fund dropdown above.  Not every fund is listed there
>5) Apply patch
>6) Now behavior is the same, only active fund are listed by default.
>7) click "Show inactive" checkbox and see all the funds in the dropdown.
>---
> .../prog/en/modules/acqui/invoice.tt          | 26 ++++++++++++++++---
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index 2348004cd6..6638449a4b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -278,13 +278,19 @@
>                                   <li>
>                                       <label for="budget_id_new">Fund: </label>
>                                       <select id="budget_id_new" name="budget_id">
>-                                          <option selected="selected" value="">No fund</option>
>+                                          <option value="">No fund</option>
>                                           [% FOREACH budget IN budgets %]
>-                                              <option value="[% budget.b_id | html %]">
>-                                              [% budget.b_txt | html %]
>-                                              </option>
>+                                              [% IF ( budget.selected ) %]
>+                                                  <option value="[% budget.b_id | html %]" selected="selected">[% budget.b_txt | html %] [% IF ( !budget.b_active ) %](inactive)[% END %]</option>
>+                                              [% ELSIF ( budget.b_active ) %]
>+                                                  <option value="[% budget.b_id | html %]">[% budget.b_txt | html %]</option>
>+                                              [% ELSE %]
>+                                                  <option value="[% budget.b_id | html %]" class="ab_inactive">[% budget.b_txt | html %] (inactive)</option>
>+                                              [% END %]
>                                           [% END %]
>                                       </select>
>+                                      <label for="showallfunds_adj" style="float:none;width:auto;">&nbsp;Show inactive:</label>
>+                                      <input type="checkbox" id="showallfunds_adj" />
>                                   </li>
>                                   <li>
>                                       <label for="encumber_new">Encumber while invoice open? </label>
>@@ -516,6 +522,18 @@
>                     $('.b_inactive').remove();
>                 }
>             });
>+            // same effort for the adjustments
>+            var adjBudgetId = $("#budget_id_new");
>+            var disabledAdjBudgetsCopy = adjBudgetId.html();
>+            $('.ab_inactive').remove();
>+            $('#showallfunds_adj').click(function() {
>+                if ($(this).is(":checked")) {
>+                    adjBudgetId.html(disabledAdjBudgetsCopy); //Puts back all the funds
>+                }
>+                else {
>+                    $('.ab_inactive').remove();
>+                }
>+            });
>         });
>     </script>
> [% END %]
>-- 
>2.17.1