Bug 23946

Summary: Remove Noun Project icons from the About page
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, gmcharlt, katrin.fischer, lucas, testopia
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Bug Depends on: 23711    
Bug Blocks:    
Attachments: Bug 23946: Remove Noun Project icons from the About page
Bug 23946: Remove Noun Project icons from the About page

Description Owen Leonard 2019-11-01 15:38:30 UTC
Bug 23711 removed all the Noun Project icons from Koha, so the attribution can be removed.
Comment 1 Owen Leonard 2019-11-01 15:56:58 UTC
Created attachment 94955 [details] [review]
Bug 23946: Remove Noun Project icons from the About page

This patch removes the part of the About page which gives attribution
for Noun Project icons on the staff client home page.

To test, apply the patch and view the About page in the staff client.
There should be no reference to Noun Project icons.
Comment 2 Katrin Fischer 2019-11-02 10:52:32 UTC
Created attachment 94960 [details] [review]
Bug 23946: Remove Noun Project icons from the About page

This patch removes the part of the About page which gives attribution
for Noun Project icons on the staff client home page.

To test, apply the patch and view the About page in the staff client.
There should be no reference to Noun Project icons.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2019-11-02 10:53:03 UTC
Basically a string patch and a logical consequence of bug 23711. PQA.
Comment 4 Martin Renvoize 2019-11-03 07:47:44 UTC
Nice work!

Pushed to master for 19.11.00