|
Description
Tomás Cohen Arazi (tcohen)
2019-11-01 18:48:31 UTC
Created attachment 94957 [details] [review] Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 95028 [details] [review] Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 95068 [details] [review] Bug 23949: Update documentation vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable kohadev cp: cannot stat '/etc/koha/z3950/*': No such file or directory Where/How is this directory created? (In reply to Jonathan Druart from comment #4) > vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable > kohadev > cp: cannot stat '/etc/koha/z3950/*': No such file or directory > > > Where/How is this directory created? I think it is missing in cp_debian_files.pl or smth (In reply to Tomás Cohen Arazi from comment #5) > (In reply to Jonathan Druart from comment #4) > > vagrant@kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable > > kohadev > > cp: cannot stat '/etc/koha/z3950/*': No such file or directory > > > > > > Where/How is this directory created? > > I think it is missing in cp_debian_files.pl or smth What about the debian package? Created attachment 95125 [details] [review] Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 95133 [details] [review] Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 95134 [details] [review] Bug 23949: Update documentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 95135 [details] [review] Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 95180 [details] [review] Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 95181 [details] [review] Bug 23949: Update documentation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 95182 [details] [review] Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 missing dependencies for 19.05.x, no backport |