Bug 23954

Summary:	Format notes in suggestion management
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	hayleypelham, lucas
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	19.11.00, 19.05.06, 18.11.12
Circulation function:
Attachments:	Bug 23954: Format notes in suggestion management Bug 23954: Format notes in suggestion management Bug 23954: Format notes in suggestion management

Description Owen Leonard 2019-11-03 21:31:31 UTC

In looking for places in the templates where we still refer to famfamfam icons I found some inline CSS in the suggestions management page. A markup mis-match means that this style hasn't been correctly applied. I would like to modify the CSS and markup so that the note stands out from the other info in the suggestions list and replace the background image icon with a Font Awesome icon.

Comment 1 Owen Leonard 2019-11-03 21:44:06 UTC

Created attachment 94982 [details] [review]
Bug 23954: Format notes in suggestion management

This patch makes minor CSS and markup changes in order to deliniate
suggestion notes from the other data in the suggestions list view.

To test you should have at least one suggestion with a note. Apply the
patch and go to Acquisitions -> Suggestions.

In the table of suggestions, check that the notes display clearly.

Comment 2 Séverine Queune 2019-11-04 09:05:43 UTC

Created attachment 94990 [details] [review]
Bug 23954: Format notes in suggestion management

This patch makes minor CSS and markup changes in order to deliniate
suggestion notes from the other data in the suggestions list view.

To test you should have at least one suggestion with a note. Apply the
patch and go to Acquisitions -> Suggestions.

In the table of suggestions, check that the notes display clearly.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Comment 3 Jonathan Druart 2019-11-07 11:15:37 UTC

Created attachment 95140 [details] [review]
Bug 23954: Format notes in suggestion management

This patch makes minor CSS and markup changes in order to deliniate
suggestion notes from the other data in the suggestions list view.

To test you should have at least one suggestion with a note. Apply the
patch and go to Acquisitions -> Suggestions.

In the table of suggestions, check that the notes display clearly.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Comment 4 Martin Renvoize (ashimema) 2019-11-07 13:27:36 UTC

Nice work!

Pushed to master for 19.11.00

Comment 5 Lucas Gass (lukeg) 2019-12-12 00:05:40 UTC

backported to 19.05.x for 19.05.06

Comment 6 Hayley Pelham 2019-12-17 03:46:28 UTC

Backported to 18.11.x for 18.11.12