Bug 23968

Summary: OPACMySummaryNote does not work
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: OPACAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: arthur.suzuki, cslone, ephetteplace, hayleypelham, katrin.fischer, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00, 19.05.10, 18.11.16
Attachments: Bug 23968: fix OPACMySummaryNote feature
Bug 23968: Add div this id around OPACMySummaryNote content
Bug 23968: fix OPACMySummaryNote feature
Bug 23968: Add div this id around OPACMySummaryNote content

Description Fridolin Somers 2019-11-05 08:51:00 UTC
The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC.
It does not display anymore.

Looks like it comes from code :
[% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %]
OPACMySummaryNote used to be a provided variable.

I propose to fix and add a div with an id to allow tunning of this specific display.
Comment 1 Fridolin Somers 2019-11-05 08:56:52 UTC
Created attachment 95039 [details] [review]
Bug 23968: fix OPACMySummaryNote feature

The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC.
It does not display anymore.

Looks like it comes from code :
[% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %]
OPACMySummaryNote used to be a provided variable.

Test plan:
1) Enable system preference OPACMySummaryNote
2) Enter some HTML into it
3) Go to OPAC and loggin
4) Check you see the HTML in opac-user.pl
5) Disable the preference
6) Check you dont see the HTML anymore
Comment 2 Fridolin Somers 2019-11-05 08:57:03 UTC
Created attachment 95040 [details] [review]
Bug 23968: Add div this id around OPACMySummaryNote content
Comment 3 Katrin Fischer 2019-11-05 11:42:54 UTC
Created attachment 95046 [details] [review]
Bug 23968: fix OPACMySummaryNote feature

The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC.
It does not display anymore.

Looks like it comes from code :
[% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %]
OPACMySummaryNote used to be a provided variable.

Test plan:
1) Enable system preference OPACMySummaryNote
2) Enter some HTML into it
3) Go to OPAC and loggin
4) Check you see the HTML in opac-user.pl
5) Disable the preference
6) Check you dont see the HTML anymore
Comment 4 Katrin Fischer 2019-11-05 11:42:58 UTC
Created attachment 95047 [details] [review]
Bug 23968: Add div this id around OPACMySummaryNote content

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2019-11-05 11:43:55 UTC
Obvious template fix, passing QA.
Comment 6 Martin Renvoize 2019-11-06 17:10:33 UTC
Nice work!

Pushed to master for 19.11.00
Comment 7 Lucas Gass 2019-12-10 22:34:59 UTC
this feature is not broken for me in 19.05.x, not backporting
Comment 8 Arthur Suzuki 2020-01-31 02:21:35 UTC
The functionality is broken for 18.11 though but patch applies fine :)
Comment 9 Chris Slone 2020-03-03 18:21:26 UTC
This appears to be bugged on 19.05 too.
Comment 10 Eric Phetteplace 2020-03-30 17:50:15 UTC
Yes this bug very much affects 19.05, we are on 19.05.08 and suffer from it.
Comment 11 Lucas Gass 2020-03-30 18:22:53 UTC
backported to 19.05.x for 19.05.10
Comment 12 Hayley Pelham 2020-04-14 01:54:51 UTC
Backported to 18.11.x for 18.11.16