Summary: | OPACMySummaryNote does not work | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | OPAC | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, cslone, ephetteplace, hayleypelham, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00, 19.05.10, 18.11.16
|
|
Circulation function: | |||
Attachments: |
Bug 23968: fix OPACMySummaryNote feature
Bug 23968: Add div this id around OPACMySummaryNote content Bug 23968: fix OPACMySummaryNote feature Bug 23968: Add div this id around OPACMySummaryNote content |
Description
Fridolin Somers
2019-11-05 08:51:00 UTC
Created attachment 95039 [details] [review] Bug 23968: fix OPACMySummaryNote feature The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC. It does not display anymore. Looks like it comes from code : [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %] OPACMySummaryNote used to be a provided variable. Test plan: 1) Enable system preference OPACMySummaryNote 2) Enter some HTML into it 3) Go to OPAC and loggin 4) Check you see the HTML in opac-user.pl 5) Disable the preference 6) Check you dont see the HTML anymore Created attachment 95040 [details] [review] Bug 23968: Add div this id around OPACMySummaryNote content Created attachment 95046 [details] [review] Bug 23968: fix OPACMySummaryNote feature The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC. It does not display anymore. Looks like it comes from code : [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %] OPACMySummaryNote used to be a provided variable. Test plan: 1) Enable system preference OPACMySummaryNote 2) Enter some HTML into it 3) Go to OPAC and loggin 4) Check you see the HTML in opac-user.pl 5) Disable the preference 6) Check you dont see the HTML anymore Created attachment 95047 [details] [review] Bug 23968: Add div this id around OPACMySummaryNote content Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Obvious template fix, passing QA. Nice work! Pushed to master for 19.11.00 this feature is not broken for me in 19.05.x, not backporting The functionality is broken for 18.11 though but patch applies fine :) This appears to be bugged on 19.05 too. Yes this bug very much affects 19.05, we are on 19.05.08 and suffer from it. backported to 19.05.x for 19.05.10 Backported to 18.11.x for 18.11.16 |