|
Description
Caroline Cyr La Rose
2019-11-11 17:00:48 UTC
Also add "lock" icon for usability (specifically colour-blind users), as per Martin's request. Created attachment 112499 [details] [review] Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text Sponsored-by: Catalyst IT Hi Caroline, I have kept the lock icon displaying in its default black colour in my patch. This is so it stands out to color-blind users. If you think it should be red please do let me know. Thanks, Alex Created attachment 112516 [details] [review] Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> (In reply to Alex Buckley from comment #3) > Hi Caroline, > > I have kept the lock icon displaying in its default black colour in my > patch. This is so it stands out to color-blind users. If you think it should > be red please do let me know. > > Thanks, > Alex Black locker sees ok to me, but I Caroline confirm that point ! Thanks Alex ! Thank you for testing Séverine! Hi Alex! Do you think you could add a space between the lock icon and the word "locked"? Otherwise, it works perfectly! Caroline Created attachment 112633 [details] [review] Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Hi Caroline and Séverine , Thanks both for testing! I've added a space in between the lock icon and the 'Locked' text which you should now see after running the yarn build command. Would you mind retesting now? Thanks, Alex Created attachment 112649 [details] [review] Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thank Alex! Thanks very much for testing Caroline! I am wondering about the use of the inline style. I know it has been there before, but as we already moved things to the scss, maybe we could finish it off here? I think it might be nicer to have both the locked and the lock in black. Red is a warnung color, but there is not really an error or danger in it being locked, so I think having both black would be ok. Created attachment 112797 [details] [review] Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 112798 [details] [review] Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Attached a follow-up simplifying things a little bit. Can you please check if that would be alright? Created attachment 112837 [details] [review] Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 112875 [details] [review] Bug 24012: Budget 'Locked" text colour changed and lock icon added Test plan: 1. Go to Administration 2. Click on Budgets 3. Add a new bdget and check the 'Lock budget' box 4. Click on the 'Inactive budgets' tab 5. Note that 'Locked' is displayed in green 6. Apply patch 7. Compile the sass files (setup detailed here:https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) by running: yarn build 8. Refresh the page and notice the 'Locked' text is now red, and there is a lock icon to the left of the text. There is a space between the lock icon and the 'Locked' text. Sponsored-by: Catalyst IT Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Created attachment 112876 [details] [review] Bug 24012: (QA follow-up) Use standard patterns - Removes the scss change in favor of adding the space to the HTML as is the usual pattern when using Font Awesome icons - Removes the span with the inline style to make things appear as black by default (no danger here in it being locked?) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thank you Katrin and Owen! On reflection I agree with you that 'Locked' probably shouldn't be displayed in red as it is not an error. Pushed to master for 20.11, thanks to everybody involved! |