| Summary: | No need to die "Not logged in" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, black23, m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 18403, 20489 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 24018: Remove die "Not logged in"
Bug 24018: Remove die "Not logged in" Bug 24018: Remove die "Not logged in" Bug 24018: Remove die "Not logged in" |
||
|
Description
Jonathan Druart
2019-11-12 15:03:27 UTC
Created attachment 95328 [details] [review] Bug 24018: Remove die "Not logged in" Jonathan, can you rebasi this patch on master? Thank you. Created attachment 97160 [details] [review] Bug 24018: Remove die "Not logged in" Created attachment 97232 [details] [review] Bug 24018: Remove die "Not logged in" Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 97476 [details] [review] Bug 24018: Remove die "Not logged in" Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note: I checked a number of edits to see which call was preceding the find or die statement. In the very most cases it is a get_template_and_user. In members/mod_debarment.pl it was a checkauth call. I saw it twice. This should be fine especially since a flagsrequired is passed too. Nice work everyone! Pushed to master for 20.05 Does not apply to 19.11.x branch. Please rebase if needed. |