|
Description
Jonathan Druart
2019-11-12 15:46:38 UTC
We have a race condition here, I guess that's why we get the "Connect failed".
kohadev-koha@c46b1ba2057e:/kohadevbox/koha$ prove t/db_dependent/Koha/Z3950Responder/Session*.t
t/db_dependent/Koha/Z3950Responder/Session2.t .. ok
t/db_dependent/Koha/Z3950Responder/Session.t ... 1/3
# Failed test 'All statuses added in one field as expected'
# at t/db_dependent/Koha/Z3950Responder/Session.t line 63.
# got: 'Checked Out, Lost, Not for Loan, Borked completely, Withdrawn, In Transit, On Hold'
# expected: 'Checked Out, Lost, Not for Loan, Damaged, Withdrawn, In Transit, On Hold'
# Failed test 'Available status added as expected'
# at t/db_dependent/Koha/Z3950Responder/Session.t line 66.
# got: 'Free as a bird'
# expected: 'Available'
# Looks like you failed 2 tests of 2.
t/db_dependent/Koha/Z3950Responder/Session.t ... 3/3
# Failed test 'add_item_status'
# at t/db_dependent/Koha/Z3950Responder/Session.t line 68.
# Looks like you failed 1 test of 3.
t/db_dependent/Koha/Z3950Responder/Session.t ... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests
Test Summary Report
-------------------
t/db_dependent/Koha/Z3950Responder/Session.t (Wstat: 256 Tests: 3 Failed: 1)
Failed test: 3
Non-zero exit status: 1
Files=2, Tests=6, 6 wallclock secs ( 0.01 usr 0.01 sys + 4.65 cusr 1.31 csys = 5.98 CPU)
Result: FAIL
Ok, maybe not.
# Failed test 'All statuses added in one field as expected'
# at t/db_dependent/Koha/Z3950Responder/Session.t line 63.
# got: 'Checked Out, Lost, Not for Loan, Borked completely, Withdrawn, In Transit, On Hold'
# expected: 'Checked Out, Lost, Not for Loan, Damaged, Withdrawn, In Transit, On Hold'
# Failed test 'Available status added as expected'
# at t/db_dependent/Koha/Z3950Responder/Session.t line 66.
# got: 'Free as a bird'
# expected: 'Available'
# Looks like you failed 2 tests of 2.
=> This happens when Session2.t is run before Session.t
To recreate:
prove t/db_dependent/Koha/Z3950Responder/Session2.t t/db_dependent/Koha/Z3950Responder/Session.t
I do not recreate the "Connect failed" when logged in to the container
Created attachment 95332 [details] [review] Bug 24022: Prevent Session2.t to fail if run after Session.t Cache must be cleaned! Created attachment 95333 [details] [review] Bug 24022: Remove unecessary delete from authorised_values Why do we need that exactly? The cache is not flushed so it should not be needed. Created attachment 95336 [details] [review] Bug 24022: Try to fix 'connect failed' I am assuming that the tests fail on Jenkins's nodes because they are too slow. The server is not setup yet when we are trying to access it. Just a guess... Note that sleep is usually a bad idea... Created attachment 95362 [details] [review] Bug 24022: Prevent Session2.t to fail if run after Session.t Cache must be cleaned! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 95363 [details] [review] Bug 24022: Remove unecessary delete from authorised_values Why do we need that exactly? The cache is not flushed so it should not be needed. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 95364 [details] [review] Bug 24022: Try to fix 'connect failed' I am assuming that the tests fail on Jenkins's nodes because they are too slow. The server is not setup yet when we are trying to access it. Just a guess... Note that sleep is usually a bad idea... Signed-off-by: Nick Clemens <nick@bywatersolutions.com> This all looks sane to me, passing QA and pushing. Nice work! Pushed to master for 19.11.00 Depends on Bug 13937 not in 19.05.x |